Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(53)

Issue 66603013: Activate Views TabbedPane tabs on mouse pressed. (Closed)

Created:
7 years, 1 month ago by msw
Modified:
7 years, 1 month ago
Reviewers:
sky
CC:
chromium-reviews, tfarina, Peter Kasting
Visibility:
Public.

Description

Activate Views TabbedPane tabs on mouse pressed. SelectTab in OnMousePressed and for ET_GESTURE_TAP_DOWN. Eliminate the intermediate TAB_PRESSED state enum. (Inactive/Active/Hovered cover the available states) BUG=252919 TEST=View TabbedPane tabs change on mouse down. This UI is used in the website settings bubble (via the page icon), and the collected cookies dialog (from the aforementioned bubble) on Windows and ChromeOS. R=sky@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=234682

Patch Set 1 #

Total comments: 2

Patch Set 2 : Limit to only the left mouse button. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -19 lines) Patch
M ui/views/controls/tabbed_pane/tabbed_pane.cc View 1 5 chunks +4 lines, -19 lines 0 comments Download

Messages

Total messages: 7 (0 generated)
msw
Hey Scott, please take a look; thanks!
7 years, 1 month ago (2013-11-12 01:47:23 UTC) #1
sky
https://codereview.chromium.org/66603013/diff/1/ui/views/controls/tabbed_pane/tabbed_pane.cc File ui/views/controls/tabbed_pane/tabbed_pane.cc (right): https://codereview.chromium.org/66603013/diff/1/ui/views/controls/tabbed_pane/tabbed_pane.cc#newcode108 ui/views/controls/tabbed_pane/tabbed_pane.cc:108: if (GetLocalBounds().Contains(event.location())) Only on left mouse button?
7 years, 1 month ago (2013-11-12 17:03:00 UTC) #2
msw
Comment addressed. Please take another look; thanks! https://codereview.chromium.org/66603013/diff/1/ui/views/controls/tabbed_pane/tabbed_pane.cc File ui/views/controls/tabbed_pane/tabbed_pane.cc (right): https://codereview.chromium.org/66603013/diff/1/ui/views/controls/tabbed_pane/tabbed_pane.cc#newcode108 ui/views/controls/tabbed_pane/tabbed_pane.cc:108: if (GetLocalBounds().Contains(event.location())) ...
7 years, 1 month ago (2013-11-12 18:48:50 UTC) #3
sky
LGTM
7 years, 1 month ago (2013-11-12 20:21:34 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/msw@chromium.org/66603013/130001
7 years, 1 month ago (2013-11-12 20:23:23 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/msw@chromium.org/66603013/130001
7 years, 1 month ago (2013-11-12 23:43:30 UTC) #6
commit-bot: I haz the power
7 years, 1 month ago (2013-11-13 00:45:20 UTC) #7
Message was sent while issue was closed.
Change committed as 234682

Powered by Google App Engine
This is Rietveld 408576698