scripts/slave/recipes/chromium_trybot.expected/no_compile_because_of_analyze.json - Issue 666023004: Use src-side launcher for telemetry_unittests in chromium_trybot recipe

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: scripts/slave/recipes/chromium_trybot.expected/no_compile_because_of_analyze.json

Issue 666023004: Use src-side launcher for telemetry_unittests in chromium_trybot recipe (Closed) Base URL: https://chromium.googlesource.com/chromium/tools/build.git@master

Patch Set: rebase & add TODO Created 6 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « scripts/slave/recipes/chromium_trybot.expected/invalid_json_without_patch.json ('k') | scripts/slave/recipes/chromium_trybot.expected/persistent_failure_and_runhooks_2_fail_test.json » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: scripts/slave/recipes/chromium_trybot.expected/no_compile_because_of_analyze.json

diff --git a/scripts/slave/recipes/chromium_trybot.expected/no_compile_because_of_analyze.json b/scripts/slave/recipes/chromium_trybot.expected/no_compile_because_of_analyze.json

index 3a798379bcade4ca5e1db6c6568aa4e0200d5ad3..5bf5f3adab24c3a73c0e93065e04ec73e210bbd8 100644

--- a/scripts/slave/recipes/chromium_trybot.expected/no_compile_because_of_analyze.json

+++ b/scripts/slave/recipes/chromium_trybot.expected/no_compile_because_of_analyze.json

@@ -98,6 +98,27 @@

"cmd": [

"python",

"-u",

+ "[SLAVE_BUILD]/src/testing/scripts/get_compile_targets.py",

+ "--output",

+ "/path/to/tmp/json",

+ "--",

+ "--build-config-fs",

+ "Release",

+ "--paths",

+ "{\"build\": \"[BUILD]\"}",

+ "--properties",

+ "{\"buildername\": \"linux_chromium_rel\", \"buildnumber\": 571, \"slavename\": \"TestSlavename\"}"

+ ],

+ "name": "get compile targets for scripts",

+ "~followup_annotations": [

+ "@@@STEP_LOG_LINE@json.output@{}@@@",

+ "@@@STEP_LOG_END@json.output@@@"

+ ]

+ },

+ {

+ "cmd": [

+ "python",

+ "-u",

"\nimport shutil\nimport sys\nshutil.copy(sys.argv[1], sys.argv[2])\n",

"[SLAVE_BUILD]/src/testing/buildbot/trybot_analyze_config.json",

"/path/to/tmp/json"

@@ -155,6 +176,12 @@

"python",

"-u",

"[SLAVE_BUILD]/src/testing/scripts/checkdeps.py",

+ "--build-config-fs",

+ "Release",

+ "--paths",

+ "{\"build\": \"[BUILD]\"}",

+ "--properties",

+ "{\"buildername\": \"linux_chromium_rel\", \"buildnumber\": 571, \"slavename\": \"TestSlavename\"}",

"run",

"--output",

"/path/to/tmp/json"