Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(619)

Issue 666003002: Added helper methods to get/set previous_cached_network_params_. (Closed)

Created:
6 years, 2 months ago by ramant (doing other things)
Modified:
6 years, 2 months ago
Reviewers:
Ryan Hamilton
CC:
chromium-reviews, cbentzel+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@Fix_test_which_times_out_77868811
Project:
chromium
Visibility:
Public.

Description

Added helper methods to get/set previous_cached_network_params_. Merging the following internal change: Add varz to track accuracy of QUIC bandwidth predictions. Plan is to use this data to calculate possible impact of using bandwidth predictions, get an idea of how accurate our predictions are. Intended varz output is something like: .../spdy4_over_quic/stk_predicted_bw_accuracy_within_5_mins .../spdy4_over_quic/stk_predicted_bw_accuracy_within_50_mins .../spdy4_over_quic/stk_predicted_bw_accuracy_within_500_mins .../spdy4_over_quic/stk_predicted_bw_accuracy_any_time .../spdy4_over_quic/max_stk_predicted_bw_accuracy_within_5_mins .../spdy4_over_quic/max_stk_predicted_bw_accuracy_within_50_mins .../spdy4_over_quic/max_stk_predicted_bw_accuracy_within_500_mins .../spdy4_over_quic/max_stk_predicted_bw_accuracy_any_time Each of these is a map of 20 buckets, covering 10% chunks of the [0%, 200%] range. For example, a bandwidth estimate from 25 minutes ago, that turns out to be 125% of the observed bandwidth, will result in the stk_predicted_bw_accuracy_within_50_mins_histogram{13} bucket being incremented. Merge internal change: 77877600 R=rch@chromium.org

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+16 lines, -0 lines) Patch
M net/quic/quic_crypto_server_stream.h View 2 chunks +5 lines, -0 lines 0 comments Download
M net/quic/quic_crypto_server_stream.cc View 2 chunks +11 lines, -0 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
ramant (doing other things)
6 years, 2 months ago (2014-10-20 19:59:19 UTC) #1
Ryan Hamilton
6 years, 2 months ago (2014-10-20 21:23:40 UTC) #2
lgtm

Might want to clean up the CL description since it includes some internal
details. Nothing important, though.

Powered by Google App Engine
This is Rietveld 408576698