chrome/common/service_process_util_win.cc - Issue 6660001: Getting service process on Mac to handle having things moved/changed underneath it.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/common/service_process_util_win.cc

Issue 6660001: Getting service process on Mac to handle having things moved/changed underneath it. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: polishing the chrome Created 9 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: chrome/common/service_process_util_win.cc

diff --git a/chrome/common/service_process_util_win.cc b/chrome/common/service_process_util_win.cc

index 32581a1f40fe35a67d89e97940a56c80a43396d9..a6385e23a2e220386c5868ab1d25c5802c57c21c 100644

--- a/chrome/common/service_process_util_win.cc

+++ b/chrome/common/service_process_util_win.cc

@@ -128,12 +128,13 @@ bool ServiceProcessState::SignalReady(

base::MessageLoopProxy* message_loop_proxy, Task* shutdown_task) {

DCHECK(state_);

DCHECK(state_->ready_event.IsValid());

+ scoped_ptr<Task> scoped_shutdown_task(shutdown_task);

if (!SetEvent(state_->ready_event.Get())) {

return false;

}

if (shutdown_task) {

state_->shutdown_monitor.reset(

- new ServiceProcessShutdownMonitor(shutdown_task));

+ new ServiceProcessShutdownMonitor(scoped_shutdown_task.release()));

state_->shutdown_monitor->Start();

}

return true;

« no previous file with comments | « chrome/common/service_process_util_unittest.cc ('k') | chrome/service/service_main.cc » ('j') | no next file with comments »