Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2237)

Unified Diff: content/public/browser/render_process_host.h

Issue 665923002: Moves RenderProcessHostImpl::init_time() to RenderProcessHost to fix broken test. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Addressed CR comments. Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/public/browser/render_process_host.h
diff --git a/content/public/browser/render_process_host.h b/content/public/browser/render_process_host.h
index c1b5c47e1d2fd5b38f90dab5febc685e76c0a7a9..4cd5390b021f9c38199a05fdb740b6add8f3abbc 100644
--- a/content/public/browser/render_process_host.h
+++ b/content/public/browser/render_process_host.h
@@ -229,6 +229,13 @@ class CONTENT_EXPORT RenderProcessHost : public IPC::Sender,
// Returns the ServiceRegistry for this process.
virtual ServiceRegistry* GetServiceRegistry() = 0;
+ // PlzNavigate
+ // Returns the time the first call to Init completed successfully (after a new
+ // renderer process was created); further calls to Init won't change this
+ // value.
+ // Note: Do not use! Will disappear after PlzNavitate is completed.
+ virtual const base::TimeTicks& GetInitTime() const = 0;
nasko 2014/10/20 19:53:57 I like Avi's suggestion. Let's decorate the name w
carlosk 2014/10/21 12:23:54 I suffixed it with ForPlzNavigate. IMO the odd sou
nasko 2014/10/21 14:13:55 I agree with jam@ that using the project name is n
carlosk 2014/10/21 15:28:13 OK, replaced it with GetInitTimeForNavigationMetri
nasko 2014/10/21 15:56:14 Ah, I like that better too!
+
// Static management functions -----------------------------------------------
// Flag to run the renderer in process. This is primarily

Powered by Google App Engine
This is Rietveld 408576698