content/browser/frame_host/navigator_impl.cc - Issue 665923002: Moves RenderProcessHostImpl::init_time() to RenderProcessHost to fix broken test.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/frame_host/navigator_impl.cc

Issue 665923002: Moves RenderProcessHostImpl::init_time() to RenderProcessHost to fix broken test. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Addressed CR comments. Created 6 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: content/browser/frame_host/navigator_impl.cc

diff --git a/content/browser/frame_host/navigator_impl.cc b/content/browser/frame_host/navigator_impl.cc

index 584f950b44185549ae195358c7322d4d71af7887..f1b75489edc2b4ace4512c24048d5a86aa33ea41 100644

--- a/content/browser/frame_host/navigator_impl.cc

+++ b/content/browser/frame_host/navigator_impl.cc

@@ -900,7 +900,7 @@ void NavigatorImpl::RecordNavigationMetrics(

RenderProcessHostImpl* process_host =

static_cast<RenderProcessHostImpl*>(site_instance->GetProcess());

bool navigation_created_new_renderer_process =

- process_host->init_time() > navigation_data_->start_time_;

+ process_host->GetInitTime() > navigation_data_->start_time_;

if (navigation_created_new_renderer_process) {

UMA_HISTOGRAM_TIMES(

"Navigation.TimeToCommit_NewRenderer_BeforeUnloadDiscounted",

« no previous file with comments | « no previous file | content/browser/renderer_host/render_process_host_impl.h » ('j') | content/browser/renderer_host/render_process_host_impl.h » ('J')