Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2185)

Unified Diff: content/browser/frame_host/navigator_impl.cc

Issue 665923002: Moves RenderProcessHostImpl::init_time() to RenderProcessHost to fix broken test. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Actually removed the now uneeded cast from RPH to RPHI. Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | content/browser/renderer_host/render_process_host_impl.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: content/browser/frame_host/navigator_impl.cc
diff --git a/content/browser/frame_host/navigator_impl.cc b/content/browser/frame_host/navigator_impl.cc
index 584f950b44185549ae195358c7322d4d71af7887..8af3076bf1c60f7babeb9b53b6cf1d53e2a950db 100644
--- a/content/browser/frame_host/navigator_impl.cc
+++ b/content/browser/frame_host/navigator_impl.cc
@@ -897,10 +897,9 @@ void NavigatorImpl::RecordNavigationMetrics(
navigation_data_.reset();
return;
}
- RenderProcessHostImpl* process_host =
- static_cast<RenderProcessHostImpl*>(site_instance->GetProcess());
bool navigation_created_new_renderer_process =
- process_host->init_time() > navigation_data_->start_time_;
+ site_instance->GetProcess()->GetInitTimeForPlzNavigate() >
+ navigation_data_->start_time_;
nasko 2014/10/21 14:50:12 nit: indent by 4 spaces
carlosk 2014/10/21 15:28:13 But this is idented by 4 spaces... I even ran git
nasko 2014/10/21 15:56:14 Hmm, I was under the impression that each breakup
if (navigation_created_new_renderer_process) {
UMA_HISTOGRAM_TIMES(
"Navigation.TimeToCommit_NewRenderer_BeforeUnloadDiscounted",
« no previous file with comments | « no previous file | content/browser/renderer_host/render_process_host_impl.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698