Move code to dump GrSurface as a png to helper files

src/gpu/GrSurfacePriv.h

Index: src/gpu/GrSurfacePriv.h
diff --git a/src/gpu/GrSurfacePriv.h b/src/gpu/GrSurfacePriv.h
index 3203671fadc4b806a6f9b639f87b46354152519a..ed34fb789d7af3120e115118505aad18e997a43c 100644
--- a/src/gpu/GrSurfacePriv.h
+++ b/src/gpu/GrSurfacePriv.h
@@ -9,6 +9,7 @@
 #define GrSurfacePriv_DEFINED
 
 #include "GrSurface.h"
+#include "../images/SkImagesSupport.h"

[jvanverth1, 2014/10/20 14:32:21]

I'm not sure this belongs in here, as there aren't any dependencies in this
header. I'd think that you'd include SkImagesSupport.h in the files that need to
save pixels, rather than GrSurfacePriv.h.

[scroggo, 2014/10/20 15:27:39]

Some more comments:

We do not fully qualify path names like this - if we need SkImagesSupport.h, its
folder should be in include_dirs in the gyp file, and the include should just be
the filename ("SkImagesSupport.h").

That said, we do not generally include files in src/.

Further, gpu should not be dependent on images.

 
 /** Class that adds methods to GrSurface that are only intended for use internal to Skia.
     This class is purely a privileged window into GrSurface. It should never have additional data
@@ -30,12 +31,6 @@ public:
      */
     bool isSameAs(const GrSurface* other) const { return fSurface->isSameAs(other); }
 
-    /**
-     * Write the contents of the surface to a PNG. Returns true if successful.
-     * @param filename      Full path to desired file
-     */
-    bool savePixels(const char* filename) { return fSurface->savePixels(filename); }
-
     bool hasPendingRead() const { return fSurface->hasPendingRead(); }
     bool hasPendingWrite() const { return fSurface->hasPendingWrite(); }
     bool hasPendingIO() const { return fSurface->hasPendingIO(); }