ui/base/ime/input_method_base.cc - Issue 665903003: Magnifier needs to follow the focus of the textfield.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: ui/base/ime/input_method_base.cc

Issue 665903003: Magnifier needs to follow the focus of the textfield. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Address code review comments. Created 6 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: ui/base/ime/input_method_base.cc

diff --git a/ui/base/ime/input_method_base.cc b/ui/base/ime/input_method_base.cc

index ed347670ef35d39d8d7de7818b7a28b40a1f9b8d..1609b5fb3bd2b5b5ec530b95dcfab59c30f9a638 100644

--- a/ui/base/ime/input_method_base.cc

+++ b/ui/base/ime/input_method_base.cc

@@ -126,6 +126,12 @@ void InputMethodBase::NotifyTextInputStateChanged(

OnTextInputStateChanged(client));

}

+void InputMethodBase::NotifyTextInputCaretBoundsChanged(

+ const TextInputClient* client) {

+ FOR_EACH_OBSERVER(

+ InputMethodObserver, observer_list_, OnCaretBoundsChanged(client));

void InputMethodBase::SetFocusedTextInputClientInternal(

TextInputClient* client) {

if (switches::IsTextInputFocusManagerEnabled())

« no previous file with comments | « ui/base/ime/input_method_base.h ('k') | ui/base/ime/input_method_chromeos.h » ('j') | no next file with comments »