Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(136)

Side by Side Diff: ui/base/ime/input_method_chromeos.h

Issue 665903003: Magnifier needs to follow the focus of the textfield. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Add test cases. Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « ui/base/ime/input_method_base.cc ('k') | ui/base/ime/input_method_chromeos.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2014 The Chromium Authors. All rights reserved. 1 // Copyright 2014 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef UI_BASE_IME_INPUT_METHOD_CHROMEOS_H_ 5 #ifndef UI_BASE_IME_INPUT_METHOD_CHROMEOS_H_
6 #define UI_BASE_IME_INPUT_METHOD_CHROMEOS_H_ 6 #define UI_BASE_IME_INPUT_METHOD_CHROMEOS_H_
7 7
8 #include <set> 8 #include <set>
9 #include <string> 9 #include <string>
10 10
(...skipping 96 matching lines...) Expand 10 before | Expand all | Expand 10 after
107 virtual void DeleteSurroundingText(int32 offset, uint32 length) override; 107 virtual void DeleteSurroundingText(int32 offset, uint32 length) override;
108 108
109 // Hides the composition text. 109 // Hides the composition text.
110 void HidePreeditText(); 110 void HidePreeditText();
111 111
112 // Callback function for IMEEngineHandlerInterface::ProcessKeyEvent. 112 // Callback function for IMEEngineHandlerInterface::ProcessKeyEvent.
113 void ProcessKeyEventDone(uint32 id, ui::KeyEvent* event, bool is_handled); 113 void ProcessKeyEventDone(uint32 id, ui::KeyEvent* event, bool is_handled);
114 114
115 // Returns whether an input field is focused. Note that password field is not 115 // Returns whether an input field is focused. Note that password field is not
116 // considered as an input field. 116 // considered as an input field.
117 bool IsInputFieldFocused(); 117 bool IsInputFieldFocused();
Jun Mukai 2014/10/22 22:22:54 It is really weird to have IsInputFieldFocused and
jennyz 2014/10/22 22:29:00 Yes, it does sound weird. The only reason I didn't
Shu Chen 2014/10/23 08:03:57 Looks like it is only used in ui/base/ime/input_me
jennyz 2014/10/23 18:10:11 Done.
jennyz 2014/10/23 18:10:11 Done.
118 118
119 // Returns true if an text input field is focused. This includes the password
120 // field.
121 bool IsTextInputFieldFocused();
122
119 // All pending key events. Note: we do not own these object, we just save 123 // All pending key events. Note: we do not own these object, we just save
120 // pointers to these object so that we can abandon them when necessary. 124 // pointers to these object so that we can abandon them when necessary.
121 // They will be deleted in ProcessKeyEventDone(). 125 // They will be deleted in ProcessKeyEventDone().
122 std::set<uint32> pending_key_events_; 126 std::set<uint32> pending_key_events_;
123 127
124 // Pending composition text generated by the current pending key event. 128 // Pending composition text generated by the current pending key event.
125 // It'll be sent to the focused text input client as soon as we receive the 129 // It'll be sent to the focused text input client as soon as we receive the
126 // processing result of the pending key event. 130 // processing result of the pending key event.
127 CompositionText composition_; 131 CompositionText composition_;
128 132
(...skipping 20 matching lines...) Expand all
149 153
150 // Used for making callbacks. 154 // Used for making callbacks.
151 base::WeakPtrFactory<InputMethodChromeOS> weak_ptr_factory_; 155 base::WeakPtrFactory<InputMethodChromeOS> weak_ptr_factory_;
152 156
153 DISALLOW_COPY_AND_ASSIGN(InputMethodChromeOS); 157 DISALLOW_COPY_AND_ASSIGN(InputMethodChromeOS);
154 }; 158 };
155 159
156 } // namespace ui 160 } // namespace ui
157 161
158 #endif // UI_BASE_IME_INPUT_METHOD_CHROMEOS_H_ 162 #endif // UI_BASE_IME_INPUT_METHOD_CHROMEOS_H_
OLDNEW
« no previous file with comments | « ui/base/ime/input_method_base.cc ('k') | ui/base/ime/input_method_chromeos.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698