Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(102)

Issue 665893006: [turbofan] add ZonePool to correctly track compiler phase memory usage (Closed)

Created:
6 years, 2 months ago by dcarney
Modified:
6 years, 2 months ago
Reviewers:
Benedikt Meurer
CC:
v8-dev
Project:
v8
Visibility:
Public.

Description

[turbofan] add ZonePool to correctly track compiler phase memory usage R=bmeurer@chromium.org BUG= Committed: https://code.google.com/p/v8/source/detail?r=24771

Patch Set 1 : #

Total comments: 1

Patch Set 2 : #

Patch Set 3 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+501 lines, -60 lines) Patch
M BUILD.gn View 1 chunk +2 lines, -0 lines 0 comments Download
M src/compiler/pipeline.h View 2 chunks +2 lines, -1 line 0 comments Download
M src/compiler/pipeline.cc View 14 chunks +30 lines, -18 lines 0 comments Download
M src/compiler/raw-machine-assembler.cc View 1 chunk +2 lines, -1 line 0 comments Download
M src/compiler/scheduler.h View 4 chunks +6 lines, -3 lines 0 comments Download
M src/compiler/scheduler.cc View 4 chunks +15 lines, -11 lines 0 comments Download
A src/compiler/zone-pool.h View 1 2 1 chunk +91 lines, -0 lines 0 comments Download
A src/compiler/zone-pool.cc View 1 2 1 chunk +133 lines, -0 lines 0 comments Download
M src/zone.cc View 1 chunk +1 line, -0 lines 0 comments Download
M test/cctest/compiler/test-instruction.cc View 1 chunk +2 lines, -1 line 0 comments Download
M test/cctest/compiler/test-scheduler.cc View 25 chunks +57 lines, -25 lines 0 comments Download
A test/unittests/compiler/zone-pool-unittest.cc View 1 1 chunk +157 lines, -0 lines 0 comments Download
M test/unittests/unittests.gyp View 1 1 chunk +1 line, -0 lines 0 comments Download
M tools/gyp/v8.gyp View 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 9 (2 generated)
dcarney
ptal I added tracking for Scheduler but there are lots of zones still missing in ...
6 years, 2 months ago (2014-10-21 10:47:25 UTC) #3
Benedikt Meurer
Some unit tests would be nice. https://codereview.chromium.org/665893006/diff/20001/src/compiler/zone-pool.cc File src/compiler/zone-pool.cc (right): https://codereview.chromium.org/665893006/diff/20001/src/compiler/zone-pool.cc#newcode84 src/compiler/zone-pool.cc:84: Zone* ZonePool::GetEmptyZone() { ...
6 years, 2 months ago (2014-10-21 10:55:33 UTC) #4
dcarney
On 2014/10/21 10:55:33, Benedikt Meurer wrote: > Some unit tests would be nice. Done. > ...
6 years, 2 months ago (2014-10-21 12:24:26 UTC) #5
Benedikt Meurer
NewEmptyZone() I guess.
6 years, 2 months ago (2014-10-21 12:25:19 UTC) #6
dcarney
On 2014/10/21 12:25:19, Benedikt Meurer wrote: > NewEmptyZone() I guess. done
6 years, 2 months ago (2014-10-21 12:29:08 UTC) #7
Benedikt Meurer
lgtm
6 years, 2 months ago (2014-10-21 12:29:29 UTC) #8
dcarney
6 years, 2 months ago (2014-10-21 12:39:03 UTC) #9
Message was sent while issue was closed.
Committed patchset #3 (id:60001) manually as 24771 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698