Re-applying reverted changes for regression confidence check + fix: ConfidenceScoretakes flat lists

tools/auto_bisect/bisect_results_test.py

 # Copyright 2014 The Chromium Authors. All rights reserved.
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 
 import os
 import unittest
 
 from bisect_results import BisectResults
 import source_control
 
@@ skipping 69 matching lines @@
 
     The score represents our confidence that the two sets of values wouldn't
     be as different as they are just by chance; that is, that some real change
     occurred between the two sets of values.
 
     Args:
       score: Expected confidence score.
       bad_values: First list of numbers.
       good_values: Second list of numbers.
     """
-    # ConfidenceScore takes a list of lists but these lists are flattened
-    # inside the function.
-    confidence = BisectResults.ConfidenceScore(
-        [[v] for v in bad_values],
-        [[v] for v in good_values])
+    confidence = BisectResults.ConfidenceScore(bad_values, good_values)
     self.assertEqual(score, confidence)
 
   def testConfidenceScoreIsZeroOnTooFewLists(self):
-    self._AssertConfidence(0.0, [], [[1], [2]])
-    self._AssertConfidence(0.0, [[1], [2]], [])
-    self._AssertConfidence(0.0, [[1]], [[1], [2]])
-    self._AssertConfidence(0.0, [[1], [2]], [[1]])
-
-  def testConfidenceScoreIsZeroOnEmptyLists(self):
-    self.assertEqual(BisectResults.ConfidenceScore([[], []], [[1], [2]]), 0.0)
-    self.assertEqual(BisectResults.ConfidenceScore([[1], [2]], [[], []]), 0.0)
+    self._AssertConfidence(0.0, [], [1, 2])
+    self._AssertConfidence(0.0, [1, 2], [])
+    self._AssertConfidence(0.0, [1], [1, 2])
+    self._AssertConfidence(0.0, [1, 2], [1])
 
   def testConfidenceScore_ZeroConfidence(self):
     # The good and bad sets contain the same values, so the confidence that
     # they're different should be zero.
     self._AssertConfidence(0.0, [4, 5, 7, 6, 8, 7], [8, 7, 6, 7, 5, 4])
 
   def testConfidenceScore_MediumConfidence(self):
     self._AssertConfidence(80.0, [0, 1, 1, 1, 2, 2], [1, 1, 1, 3, 3, 4])
 
   def testConfidenceScore_HighConfidence(self):
@@ skipping 133 matching lines @@
     revision_states[3].value = {'values': [100, 105, 95]}
     revision_states[4].value = {'values': [100, 105, 95]}
     results = BisectResults(self.mock_bisect_state, self.mock_depot_registry,
                             self.mock_opts, self.mock_warnings)
     self.assertEqual(0, results.confidence)
     self.assertEqual(1, len(results.warnings))
 
 
 if __name__ == '__main__':
   unittest.main()