Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(563)

Issue 665893002: Change SecurityOrigin from ThreadSafeRefCounted to RefCounted (Closed)

Created:
6 years, 2 months ago by hiroshige
Modified:
6 years, 1 month ago
CC:
blink-reviews, mkwst+moarreviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Project:
blink
Visibility:
Public.

Description

Change SecurityOrigin from ThreadSafeRefCounted to RefCounted SecurityOrigin should be thread-local and therefore RefCounted. BUG=415865 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=185270

Patch Set 1 #

Patch Set 2 : Rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M Source/platform/weborigin/SecurityOrigin.h View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 13 (4 generated)
hiroshige
PTAL. As you mentioned in https://codereview.chromium.org/578283002/, SecurityOrigin should be RefCounted. When we make SecurityOrigin RefCounted, ...
6 years, 1 month ago (2014-11-06 11:13:50 UTC) #2
hiroshige
tsepez@, could you take a look as a platform/weborigin owner? Thanks.
6 years, 1 month ago (2014-11-06 11:28:15 UTC) #4
Mike West
LGTM. Let's see what explodes.
6 years, 1 month ago (2014-11-06 11:37:11 UTC) #6
Mike West
(Please change the CL description to note that you're moving from thread-safe refcounted to refcounted, ...
6 years, 1 month ago (2014-11-06 11:37:44 UTC) #7
Tom Sepez
Have you tried building this with tsan just to be sure?
6 years, 1 month ago (2014-11-06 18:31:43 UTC) #8
hiroshige
On 2014/11/06 18:31:43, Tom Sepez wrote: > Have you tried building this with tsan just ...
6 years, 1 month ago (2014-11-10 08:00:57 UTC) #9
Tom Sepez
> I built with TSan and ran webkit_unit_tests and Layout Tests, > looked at TSan ...
6 years, 1 month ago (2014-11-10 17:33:54 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/665893002/20001
6 years, 1 month ago (2014-11-13 05:33:18 UTC) #12
commit-bot: I haz the power
6 years, 1 month ago (2014-11-13 06:03:11 UTC) #13
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as 185270

Powered by Google App Engine
This is Rietveld 408576698