Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1226)

Issue 665873002: Set LLVM_SYMBOLIZER_PATH in test_env.py. (Closed)

Created:
6 years, 2 months ago by Vadim Sh.
Modified:
6 years, 2 months ago
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Set LLVM_SYMBOLIZER_PATH in test_env.py. Hopefully it would fix mysterious crashes of browser_tests under ASAN on Swarming mac. runtest.py (that is NOT used by Swarming) does set LLVM_SYMBOLIZER_PATH already. Looks like this bit of logic wasn't copy-pasted into test_env.py. BUG=424280 R=earthdok@chromium.org,glider@chromium.org Committed: https://crrev.com/5cf3c44e326fc9510ab117730f23fed380b6eec8 Cr-Commit-Position: refs/heads/master@{#300244}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -0 lines) Patch
M testing/test_env.py View 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 7 (1 generated)
Vadim Sh.
PTAL For the reference, here's where it is set in runtest.py: https://code.google.com/p/chromium/codesearch#chromium/tools/build/scripts/slave/runtest.py&l=1900 llvm-symbolizer binary is ...
6 years, 2 months ago (2014-10-20 07:22:47 UTC) #1
earthdok
On 2014/10/20 07:22:47, Vadim Sh. wrote: > PTAL > > For the reference, here's where ...
6 years, 2 months ago (2014-10-20 09:52:37 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/665873002/1
6 years, 2 months ago (2014-10-20 09:53:49 UTC) #4
commit-bot: I haz the power
Committed patchset #1 (id:1)
6 years, 2 months ago (2014-10-20 10:22:46 UTC) #5
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/5cf3c44e326fc9510ab117730f23fed380b6eec8 Cr-Commit-Position: refs/heads/master@{#300244}
6 years, 2 months ago (2014-10-20 10:23:28 UTC) #6
Alexander Potapenko
6 years, 2 months ago (2014-10-20 15:22:25 UTC) #7
Message was sent while issue was closed.
Doesn't asan_symbolize.py set LLVM_SYMBOLIZER_PATH already?

Powered by Google App Engine
This is Rietveld 408576698