Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(466)

Issue 665863002: Allows to fire VKEY_UNKNOWN key events. (Closed)

Created:
6 years, 2 months ago by Yuki
Modified:
6 years, 2 months ago
Reviewers:
sky
CC:
chromium-reviews, sadrul, ben+aura_chromium.org, kalyank
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Allows to fire VKEY_UNKNOWN key events. On Linux, we have keys with keycode=VKEY_UNKNOWN, for example, ISO_LEVEL3_LATCH key. We have to emit keydown/up events appropriately even if keycode=VKEY_UNKNOWN. Just FYI: Firefox also fires keyevents with keycode=0, so the behavior will be compatible. Compared to IE and Chrome on Windows, it's still compatible because there is no such key as ISO_LEVEL3_LATCH, etc. on Windows. BUG=402320 TEST=Done manually. Committed: https://crrev.com/6c879fbd35d14af9ca4fe53bc622edac2d3fd5f1 Cr-Commit-Position: refs/heads/master@{#300438}

Patch Set 1 #

Patch Set 2 : Updated a unittest. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -7 lines) Patch
M ui/aura/window_event_dispatcher_unittest.cc View 1 1 chunk +3 lines, -3 lines 0 comments Download
M ui/aura/window_targeter.cc View 1 chunk +0 lines, -4 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
Yuki
Scott, could you review this CL as an owner of ui/aura/ ?
6 years, 2 months ago (2014-10-20 07:03:23 UTC) #2
sky
LGTM
6 years, 2 months ago (2014-10-20 19:45:21 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/665863002/40001
6 years, 2 months ago (2014-10-21 08:32:11 UTC) #6
commit-bot: I haz the power
Committed patchset #2 (id:40001)
6 years, 2 months ago (2014-10-21 09:29:30 UTC) #7
commit-bot: I haz the power
6 years, 2 months ago (2014-10-21 09:31:54 UTC) #8
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/6c879fbd35d14af9ca4fe53bc622edac2d3fd5f1
Cr-Commit-Position: refs/heads/master@{#300438}

Powered by Google App Engine
This is Rietveld 408576698