dart/runtime/bin/eventhandler.h - Issue 665823007: Several bugfixes in dart:io's handing of sockets

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: dart/runtime/bin/eventhandler.h

Issue 665823007: Several bugfixes in dart:io's handing of sockets (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge

Patch Set: Added suppression ServerSocketReference regression test for nonlinux OSes Created 6 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: dart/runtime/bin/eventhandler.h

diff --git a/dart/runtime/bin/eventhandler.h b/dart/runtime/bin/eventhandler.h

index 54845d0e3f3517e43a9170a8ac6c8e8312ffe272..3b40be3660179501a8e549d94c877e009c39df3e 100644

--- a/dart/runtime/bin/eventhandler.h

+++ b/dart/runtime/bin/eventhandler.h

@@ -29,6 +29,14 @@ enum MessageFlags {

kPipe = 17,

};

+#define COMMAND_MASK ((1 << kCloseCommand) | \

+ (1 << kShutdownReadCommand) | \

+ (1 << kShutdownWriteCommand) | \

+ (1 << kReturnTokenCommand))

+#define IS_COMMAND(data, command_bit) \

+ ((data & COMMAND_MASK) == (1 << command_bit)) // NOLINT

Søren Gjesse 2014/10/24 08:28:24 Two spaces before //

kustermann 2014/10/24 08:55:40 Done.

+#define ASSERT_NO_COMMAND(data) ASSERT((data & COMMAND_MASK) == 0) // NOLINT

Søren Gjesse 2014/10/24 08:28:24 ditto.

kustermann 2014/10/24 08:55:40 Done.

+#define TOKEN_COUNT(data) (data & ((1 << kCloseCommand) - 1))

class TimeoutQueue {

private:

« no previous file with comments | « no previous file | dart/runtime/bin/eventhandler_android.cc » ('j') | no next file with comments »