Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(162)

Side by Side Diff: net/quic/quic_fec_group.cc

Issue 665823004: Replace calls to set.count() with ContainsKey in QUIC. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@Allow_QUIC_BBR_TCP_sender_to_pace_77668996
Patch Set: Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « net/quic/quic_connection.cc ('k') | net/quic/quic_session.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "net/quic/quic_fec_group.h" 5 #include "net/quic/quic_fec_group.h"
6 6
7 #include <limits> 7 #include <limits>
8 8
9 #include "base/basictypes.h" 9 #include "base/basictypes.h"
10 #include "base/logging.h" 10 #include "base/logging.h"
11 #include "base/stl_util.h"
11 12
12 using base::StringPiece; 13 using base::StringPiece;
13 using std::numeric_limits; 14 using std::numeric_limits;
14 using std::set; 15 using std::set;
15 16
16 namespace net { 17 namespace net {
17 18
18 namespace { 19 namespace {
19 const QuicPacketSequenceNumber kNoSequenceNumber = kuint64max; 20 const QuicPacketSequenceNumber kNoSequenceNumber = kuint64max;
20 } // namespace 21 } // namespace
21 22
22 QuicFecGroup::QuicFecGroup() 23 QuicFecGroup::QuicFecGroup()
23 : min_protected_packet_(kNoSequenceNumber), 24 : min_protected_packet_(kNoSequenceNumber),
24 max_protected_packet_(kNoSequenceNumber), 25 max_protected_packet_(kNoSequenceNumber),
25 payload_parity_len_(0), 26 payload_parity_len_(0),
26 effective_encryption_level_(NUM_ENCRYPTION_LEVELS) { 27 effective_encryption_level_(NUM_ENCRYPTION_LEVELS) {
27 } 28 }
28 29
29 QuicFecGroup::~QuicFecGroup() {} 30 QuicFecGroup::~QuicFecGroup() {}
30 31
31 bool QuicFecGroup::Update(EncryptionLevel encryption_level, 32 bool QuicFecGroup::Update(EncryptionLevel encryption_level,
32 const QuicPacketHeader& header, 33 const QuicPacketHeader& header,
33 StringPiece decrypted_payload) { 34 StringPiece decrypted_payload) {
34 if (received_packets_.count(header.packet_sequence_number) != 0) { 35 if (ContainsKey(received_packets_, header.packet_sequence_number)) {
35 return false; 36 return false;
36 } 37 }
37 if (min_protected_packet_ != kNoSequenceNumber && 38 if (min_protected_packet_ != kNoSequenceNumber &&
38 max_protected_packet_ != kNoSequenceNumber && 39 max_protected_packet_ != kNoSequenceNumber &&
39 (header.packet_sequence_number < min_protected_packet_ || 40 (header.packet_sequence_number < min_protected_packet_ ||
40 header.packet_sequence_number > max_protected_packet_)) { 41 header.packet_sequence_number > max_protected_packet_)) {
41 DLOG(ERROR) << "FEC group does not cover received packet: " 42 DLOG(ERROR) << "FEC group does not cover received packet: "
42 << header.packet_sequence_number; 43 << header.packet_sequence_number;
43 return false; 44 return false;
44 } 45 }
(...skipping 116 matching lines...) Expand 10 before | Expand all | Expand 10 after
161 } 162 }
162 163
163 size_t QuicFecGroup::NumMissingPackets() const { 164 size_t QuicFecGroup::NumMissingPackets() const {
164 if (min_protected_packet_ == kNoSequenceNumber) 165 if (min_protected_packet_ == kNoSequenceNumber)
165 return numeric_limits<size_t>::max(); 166 return numeric_limits<size_t>::max();
166 return (max_protected_packet_ - min_protected_packet_ + 1) - 167 return (max_protected_packet_ - min_protected_packet_ + 1) -
167 received_packets_.size(); 168 received_packets_.size();
168 } 169 }
169 170
170 } // namespace net 171 } // namespace net
OLDNEW
« no previous file with comments | « net/quic/quic_connection.cc ('k') | net/quic/quic_session.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698