Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(669)

Issue 665823002: Fix MacViews views_unittest simulate FullScreen test for 10.7+ SDKs (Closed)

Created:
6 years, 2 months ago by tapted
Modified:
6 years, 2 months ago
Reviewers:
Robert Sesek
CC:
chromium-reviews, tfarina, erikwright+watch_chromium.org, chrome-apps-syd-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Fix MacViews views_unittest simulate FullScreen test for 10.7+ SDKs bridged_native_widget_unittest.mm currently fails to compile on 10.7+ SDKs because there is no such thing as NSWindowDidFailToEnterFullScreenNotification (whoops). The failures don't go through NSNotificationCenter, but to the NSWindowDelegate protocol directly. So, add a dummy protocol for 10.6 and, in the simulate fullscreen failure test, send windowDidFailTo{Enter,Exit}FullScreen to the window delegate directly. Call via `id` so the test compiles on 10.6 SDKs, but return early so the tests pass when actually running on 10.6. BUG=378134 TEST=By tracing the simulation test, and manually to generate an actual failure. Committed: https://crrev.com/4863f1de058a942ef677ccc05805ea75b9ee4cb9 Cr-Commit-Position: refs/heads/master@{#300366}

Patch Set 1 #

Patch Set 2 : Do something sensible when running on Snow Leopard #

Unified diffs Side-by-side diffs Delta from patch set Stats (+25 lines, -18 lines) Patch
M base/mac/sdk_forward_declarations.h View 1 chunk +4 lines, -5 lines 0 comments Download
M base/mac/sdk_forward_declarations.mm View 1 chunk +0 lines, -6 lines 0 comments Download
M ui/views/cocoa/bridged_native_widget_unittest.mm View 1 6 chunks +21 lines, -7 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
tapted
Hi Robert, PTAL. I missed that the simulated test wasn't calling these functions since they ...
6 years, 2 months ago (2014-10-20 05:47:09 UTC) #2
Robert Sesek
LGTM
6 years, 2 months ago (2014-10-20 15:07:25 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/665823002/20001
6 years, 2 months ago (2014-10-20 21:25:27 UTC) #5
commit-bot: I haz the power
Committed patchset #2 (id:20001)
6 years, 2 months ago (2014-10-20 22:45:13 UTC) #6
commit-bot: I haz the power
6 years, 2 months ago (2014-10-20 22:46:30 UTC) #7
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/4863f1de058a942ef677ccc05805ea75b9ee4cb9
Cr-Commit-Position: refs/heads/master@{#300366}

Powered by Google App Engine
This is Rietveld 408576698