Revert of Support modal windows

Revert of Support modal windows (patchset #4 id:80001 of https://codereview.chromium.org/662763002/)

Reason for revert:
Reverting because this CL because WithOrWithoutTargeter.* introduced a memory leak and made all of the Athena Asan tests fail http://build.chromium.org/p/chromium.memory/builders/Linux%20Chromium%20OS%20ASan%20LSan%20Tests%20(1)

Based on tools/lsan/suppressions.txt reverting is now preferred over adding a suppression

Original issue's description:
> Support modal windows
>
> * New ContainerParams
>  -  default_parent to specify the default parent when no
>     transient parent is specified.
>  - modal_container_priority now controls the modal container
>    used for a modal window created for the given container.
>  - if not specified, it will fallback downwards to find one.
>  - if window is specified as always_on_top, it will use top
>    most modal container.
>
> * Changed network selector/shutdown dialog to use the new API.
>
> * Other change:
>  Separated test windows to athena/test/base/test_windows.h
>
> BUG=410499
> TBR=sky@chromium.org,reed@chromium.org
> TEST=coverd by unit tests
>
> Committed: https://crrev.com/4903fd36b2b36f00efeb1b7bba81b7de6e9457a3
> Cr-Commit-Position: refs/heads/master@{#300192}

TBR=mukai@chromium.org,sky@chromium.org,reed@chromium.org,oshima@chromium.org
NOTREECHECKS=true
NOTRY=true
BUG=410499
Committed: https://crrev.com/d075289e3561d3c5ae0b36c8bb5b3f54dd8899ee
Cr-Commit-Position: refs/heads/master@{#300226}

[pkotwicz, 2014-10-20 00:45:07]

Created Revert of Support modal windows

[commit-bot: I haz the power, 2014-10-20 00:45:55]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/665803003/1

[pkotwicz, 2014-10-20 00:48:16]

Sample Asan output

HomeCardTest.ToggleOverviewWithVirtualKeyboard (run #1):
[ RUN      ] HomeCardTest.ToggleOverviewWithVirtualKeyboard
Xlib:  extension "RANDR" missing on display ":9".
[       OK ] HomeCardTest.ToggleOverviewWithVirtualKeyboard (1145 ms)
[----------] 1 test from HomeCardTest (1145 ms total)

[----------] Global test environment tear-down
[==========] 1 test from 1 test case ran. (1145 ms total)
[  PASSED  ] 1 test.

=================================================================
==13412==ERROR: LeakSanitizer: detected memory leaks

Direct leak of 16 byte(s) in 2 object(s) allocated from:
    #0 0x4bea7b in operator new(unsigned long)
(/mnt/data/b/build/slave/Linux_Chromium_OS_ASan_LSan_Tests__1_/build/src/out/Release/athena_unittests+0x4bea7b)
    #1 0x559faa in
athena::gtest_WithOrWithoutTargeterScreenManagerTargeterTest_EvalGenerator_()
athena/screen/screen_manager_unittest.cc:282:1
    #2 0x55c96c in
testing::internal::ParameterizedTestCaseInfo\u003Cathena::(anonymous
namespace)::ScreenManagerTargeterTest>::RegisterTests()
testing/gtest/include/gtest/internal/gtest-param-util.h:495:47
    #3 0x5de280 in RegisterTests
testing/gtest/include/gtest/internal/gtest-param-util.h:602:8
    #4 0x5de280 in RegisterParameterizedTests testing/gtest/src/gtest.cc:2574
    #5 0x5de280 in testing::internal::UnitTestImpl::PostFlagParsingInit()
testing/gtest/src/gtest.cc:4401
    #6 0x5e20e5 in void testing::internal::InitGoogleTestImpl\u003Cchar>(int*,
char**) testing/gtest/src/gtest.cc:5267:3
    #7 0x570a50a in InitializeFromCommandLine base/test/test_suite.cc:118:3
    #8 0x570a50a in base::TestSuite::TestSuite(int, char**)
base/test/test_suite.cc:94
    #9 0x55f8a6 in AthenaTestSuite athena/test/base/athena_unittests.cc:21:66
    #10 0x55f8a6 in main athena/test/base/athena_unittests.cc:49
    #11 0x7f36b121b76c in __libc_start_main
/build/buildd/eglibc-2.15/csu/libc-start.c:226

[commit-bot: I haz the power, 2014-10-20 00:48:38]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2014-10-20 00:49:21]

Patchset 1 (id:??) landed as
https://crrev.com/d075289e3561d3c5ae0b36c8bb5b3f54dd8899ee
Cr-Commit-Position: refs/heads/master@{#300226}

[oshima, 2014-10-20 16:49:35]

Thank you for revert. I fixed the leak and will land.

On Sun, Oct 19, 2014 at 5:49 PM, <commit-bot@chromium.org> wrote:

> Patchset 1 (id:??) landed as
> https://crrev.com/d075289e3561d3c5ae0b36c8bb5b3f54dd8899ee
> Cr-Commit-Position: refs/heads/master@{#300226}
>
> https://codereview.chromium.org/665803003/
>

To unsubscribe from this group and stop receiving emails from it, send an email
to chromium-reviews+unsubscribe@chromium.org.