Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(408)

Issue 665773003: Classes: implement 'new super'. (Closed)

Created:
6 years, 2 months ago by Dmitry Lomov (no reviews)
Modified:
6 years, 2 months ago
CC:
v8-dev
Project:
v8
Visibility:
Public.

Description

Patch Set 1 #

Patch Set 2 : stray edit #

Total comments: 2

Patch Set 3 : Patch for landing #

Patch Set 4 : debug compilation fixed #

Unified diffs Side-by-side diffs Delta from patch set Stats (+104 lines, -30 lines) Patch
M src/arm/full-codegen-arm.cc View 1 2 3 3 chunks +15 lines, -5 lines 0 comments Download
M src/arm64/full-codegen-arm64.cc View 1 2 3 3 chunks +15 lines, -5 lines 0 comments Download
M src/full-codegen.h View 1 chunk +2 lines, -0 lines 0 comments Download
M src/ia32/full-codegen-ia32.cc View 1 2 3 3 chunks +14 lines, -4 lines 0 comments Download
M src/x64/full-codegen-x64.cc View 1 2 3 3 chunks +14 lines, -4 lines 0 comments Download
M test/mjsunit/harmony/super.js View 3 chunks +44 lines, -12 lines 0 comments Download

Messages

Total messages: 7 (1 generated)
Dmitry Lomov (no reviews)
PTAL
6 years, 2 months ago (2014-10-22 16:51:48 UTC) #2
Igor Sheludko
lgtm with a nit: https://codereview.chromium.org/665773003/diff/20001/src/x64/full-codegen-x64.cc File src/x64/full-codegen-x64.cc (right): https://codereview.chromium.org/665773003/diff/20001/src/x64/full-codegen-x64.cc#newcode2986 src/x64/full-codegen-x64.cc:2986: DCHECK(super_ref != NULL); We have ...
6 years, 2 months ago (2014-10-23 07:37:23 UTC) #3
Dmitry Lomov (no reviews)
Patch for landing
6 years, 2 months ago (2014-10-23 07:55:03 UTC) #4
Dmitry Lomov (no reviews)
https://codereview.chromium.org/665773003/diff/20001/src/x64/full-codegen-x64.cc File src/x64/full-codegen-x64.cc (right): https://codereview.chromium.org/665773003/diff/20001/src/x64/full-codegen-x64.cc#newcode2986 src/x64/full-codegen-x64.cc:2986: DCHECK(super_ref != NULL); On 2014/10/23 07:37:23, Igor Sheludko wrote: ...
6 years, 2 months ago (2014-10-23 07:55:19 UTC) #5
Dmitry Lomov (no reviews)
Committed patchset #3 (id:40001) manually as 24822 (presubmit successful).
6 years, 2 months ago (2014-10-23 08:12:02 UTC) #6
Dmitry Lomov (no reviews)
6 years, 2 months ago (2014-10-23 08:32:35 UTC) #7
Message was sent while issue was closed.
Committed patchset #4 (id:60001) manually as 24825 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698