Mojo JS Bindings: Simplify sharing services for content-provided JS applications

mojo/apps/js/content_handler_impl.cc

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "mojo/apps/js/content_handler_impl.h"
 
 #include "mojo/apps/js/application_delegate_impl.h"
 #include "mojo/apps/js/js_app.h"
 #include "mojo/common/data_pipe_utils.h"
 
 namespace mojo {
 namespace apps {
 
 class ContentHandlerJSApp : public JSApp {
  public:
   ContentHandlerJSApp(ApplicationDelegateImpl* app_delegate_impl,
-                      URLResponsePtr content)
+                      URLResponsePtr content,
+                      ScopedMessagePipeHandle sp)

[Aaron Boodman, 2014/10/29 17:12:51]

Same thing here -- I would prefer to see the strong types in C++ until the last
minute when they go into JS. Or even past the last minute and leave it to Gin to
convert them.

[hansmuller, 2014/10/29 22:43:40]

I tried to do this but was thwarted by base::Bind().

       : JSApp(app_delegate_impl),
-        content_(content.Pass()) {
+        content_(content.Pass()),
+        requestor_message_pipe_handle_(sp.Pass()) {
   }
 
   bool Load(std::string* source, std::string* file_name) override {
     *file_name = content_->url;
     if (content_.is_null())
       return false;
     return common::BlockingCopyToString(content_->body.Pass(), source);
   }
 
+  virtual Handle RequestorMessagePipeHandle() override {
+    return requestor_message_pipe_handle_.release();
+  }
+
  private:
   URLResponsePtr content_;
+  ScopedMessagePipeHandle requestor_message_pipe_handle_;
 };
 
 
 ContentHandlerImpl::ContentHandlerImpl(ApplicationDelegateImpl* app)
     : app_delegate_impl_(app) {
 }
 
 ContentHandlerImpl::~ContentHandlerImpl() {
 }
 
 void ContentHandlerImpl::OnConnect(
     const mojo::String& requestor_url,
     URLResponsePtr content,
     InterfaceRequest<ServiceProvider> service_provider) {
+  ScopedMessagePipeHandle sp(service_provider.PassMessagePipe());
   scoped_ptr<JSApp> js_app(
-      new ContentHandlerJSApp(app_delegate_impl_, content.Pass()));
+      new ContentHandlerJSApp(app_delegate_impl_, content.Pass(), sp.Pass()));
   app_delegate_impl_->StartJSApp(js_app.Pass());
 }
 
 }  // namespace apps
 }  // namespace mojo