components/data_reduction_proxy/core/browser/data_reduction_proxy_settings_test_utils.cc - Issue 665703002: Activate data reduction proxy after profile initialization is complete.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/data_reduction_proxy/core/browser/data_reduction_proxy_settings_test_utils.cc

Issue 665703002: Activate data reduction proxy after profile initialization is complete. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Fix tests. Created 6 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« components/data_reduction_proxy/core/browser/data_reduction_proxy_settings.cc ('K') | « components/data_reduction_proxy/core/browser/data_reduction_proxy_settings.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/data_reduction_proxy/core/browser/data_reduction_proxy_settings_test_utils.cc

diff --git a/components/data_reduction_proxy/core/browser/data_reduction_proxy_settings_test_utils.cc b/components/data_reduction_proxy/core/browser/data_reduction_proxy_settings_test_utils.cc

index 3e02cc844523f3145894e1706cc02b21e5da0bfa..26ec584a92a9f11b73f6dd8e744cd28c523eacaf 100644

--- a/components/data_reduction_proxy/core/browser/data_reduction_proxy_settings_test_utils.cc

+++ b/components/data_reduction_proxy/core/browser/data_reduction_proxy_settings_test_utils.cc

@@ -275,11 +275,6 @@ void DataReductionProxySettingsTestBase::CheckOnPrefChange(

void DataReductionProxySettingsTestBase::CheckInitDataReductionProxy(

bool enabled_at_startup) {

base::MessageLoopForUI loop;

- SetProbeResult(kProbeURLWithOKResponse,

- "OK",

- FetchResult(enabled_at_startup, true),

- true,

- enabled_at_startup ? 1 : 0);

scoped_ptr<DataReductionProxyConfigurator> configurator(

new TestDataReductionProxyConfig());

settings_->SetProxyConfigurator(configurator.get());

@@ -295,7 +290,6 @@ void DataReductionProxySettingsTestBase::CheckInitDataReductionProxy(

base::Unretained(this)));

base::MessageLoop::current()->RunUntilIdle();

- CheckProxyConfigs(enabled_at_startup, false, false);

EXPECT_EQ(enabled_at_startup, proxy_enabled_);

}