components/data_reduction_proxy/core/browser/data_reduction_proxy_settings.h - Issue 665703002: Activate data reduction proxy after profile initialization is complete.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/data_reduction_proxy/core/browser/data_reduction_proxy_settings.h

Issue 665703002: Activate data reduction proxy after profile initialization is complete. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Fix tests. Created 6 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/profiles/profile_manager.cc ('K') | « chrome/browser/profiles/profile_manager.cc ('k') | components/data_reduction_proxy/core/browser/data_reduction_proxy_settings.cc » ('j') | components/data_reduction_proxy/core/browser/data_reduction_proxy_settings.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/data_reduction_proxy/core/browser/data_reduction_proxy_settings.h

diff --git a/components/data_reduction_proxy/core/browser/data_reduction_proxy_settings.h b/components/data_reduction_proxy/core/browser/data_reduction_proxy_settings.h

index 68f152e67178306031f2565194a18aaae061b728..4f07335efb719b06805d66d3a2a3ef59eaa6b70e 100644

--- a/components/data_reduction_proxy/core/browser/data_reduction_proxy_settings.h

+++ b/components/data_reduction_proxy/core/browser/data_reduction_proxy_settings.h

@@ -181,6 +181,10 @@ class DataReductionProxySettings

// net::URLFetcherDelegate:

void OnURLFetchComplete(const net::URLFetcher* source) override;

+ // Configures data reduction proxy and makes a request to the prober URL to

bengr 2014/10/22 00:46:43 probe

Not at Google. Contact bengr 2014/10/22 20:03:42 Done.

+ // determine server availability.

bengr 2014/10/22 00:46:43 Describe what "at_startup" means.

Not at Google. Contact bengr 2014/10/22 20:03:42 Done.

+ void MaybeActivateDataReductionProxy(bool at_startup);

protected:

void InitPrefMembers();

@@ -276,8 +280,6 @@ class DataReductionProxySettings

void ResetDataReductionStatistics();

- void MaybeActivateDataReductionProxy(bool at_startup);

// Requests the proxy probe URL, if one is set. If unable to do so, disables

// the proxy, if enabled. Otherwise enables the proxy if disabled by a probe

// failure.