Activate data reduction proxy after profile initialization is complete.

chrome/browser/profiles/profile_manager.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/profiles/profile_manager.h"
 
 #include <set>
 
 #include "base/bind.h"
 #include "base/command_line.h"
 #include "base/debug/trace_event.h"
 #include "base/deferred_sequenced_task_runner.h"
 #include "base/files/file_enumerator.h"
 #include "base/files/file_path.h"
 #include "base/files/file_util.h"
 #include "base/metrics/histogram.h"
 #include "base/prefs/pref_service.h"
 #include "base/prefs/scoped_user_pref_update.h"
 #include "base/strings/string_number_conversions.h"
 #include "base/strings/string_util.h"
 #include "base/strings/utf_string_conversions.h"
 #include "chrome/browser/bookmarks/bookmark_model_factory.h"
 #include "chrome/browser/browser_process.h"
 #include "chrome/browser/chrome_notification_types.h"
 #include "chrome/browser/content_settings/host_content_settings_map.h"
 #include "chrome/browser/download/download_service.h"
 #include "chrome/browser/download/download_service_factory.h"
+#include "chrome/browser/net/spdyproxy/data_reduction_proxy_chrome_settings.h"
+#include "chrome/browser/net/spdyproxy/data_reduction_proxy_chrome_settings_factory.h"
 #include "chrome/browser/password_manager/password_store_factory.h"
 #include "chrome/browser/prefs/incognito_mode_prefs.h"
 #include "chrome/browser/profiles/bookmark_model_loaded_observer.h"
 #include "chrome/browser/profiles/profile_avatar_icon_util.h"
 #include "chrome/browser/profiles/profile_destroyer.h"
 #include "chrome/browser/profiles/profile_info_cache.h"
 #include "chrome/browser/profiles/profile_metrics.h"
 #include "chrome/browser/profiles/profiles_state.h"
 #include "chrome/browser/profiles/startup_task_runner_service.h"
 #include "chrome/browser/profiles/startup_task_runner_service_factory.h"
@@ skipping 936 matching lines @@
   RunCallbacks(callbacks, profile,
                profile ? Profile::CREATE_STATUS_INITIALIZED :
                          Profile::CREATE_STATUS_LOCAL_FAIL);
 }
 
 void ProfileManager::DoFinalInit(Profile* profile, bool go_off_the_record) {
   DoFinalInitForServices(profile, go_off_the_record);
   AddProfileToCache(profile);
   DoFinalInitLogging(profile);
 
+  DataReductionProxyChromeSettingsFactory::GetForBrowserContext(profile)->
+      MaybeActivateDataReductionProxy(true);

[sgurun-gerrit only, 2014/10/22 20:25:59]

I am not the owner of this code, but this custom code for DRP here just looks
like a hack to me. is this the only way of achieving this goal?

[Not at Google. Contact bengr, 2014/10/22 20:55:29]

This code was simply moved from being called through ProfileImpl::DoFinalInit()
to here(ProfileManger::DoFinalInit()), so it's about as good or bad as the
previous location. Note that ProfileImpl::DoFinalInit() continues to have custom
DRP code and the call is similar to this one.

I don't know of a better location. We could see if mmenke has suggestions.

[mmenke, 2014/10/23 17:17:26]

Why can't we just do all this on the IO thread?  (Stuff meaning doing the probe,
figuring out what settings to use, etc)?

[Not at Google. Contact bengr, 2014/10/23 17:29:33]

The probe can only be done after profile initialization is complete. More
specifically, only after DoFinalInitForServices(..) on line 982 above. If probe
is done before DoFinalInitForServices(..), then it causes the crash mentioned in
the bug.

SetupDataReductionProxy(..) in io thread is called before the above method
executes, so cannot do it there. Is there any location on io thread which works
for this purpose?

[mmenke, 2014/10/23 17:36:59]

I thought the issue was when you could first make a URLRequest?  You should be
able to them at the end of ProfileIOData::Init.

[Not at Google. Contact bengr, 2014/10/23 17:39:42]

Yes, we connect to the probe with a URLRequest.

[Not at Google. Contact bengr, 2014/10/23 17:40:53]

Trying to connect to the probe with a URLRequest at the end of
ProfileIOData::Init causes the crash mentioned in the bug.

[mmenke, 2014/10/23 17:43:32]

Skimming over the bug, I see no mention of this function, or even ProfileIOData.
 I do see mention of ProfileImpl::DoFinalInit.

+
   ProfileMetrics::LogNumberOfProfiles(this);
   content::NotificationService::current()->Notify(
       chrome::NOTIFICATION_PROFILE_ADDED,
       content::Source<Profile>(profile),
       content::NotificationService::NoDetails());
 }
 
 void ProfileManager::DoFinalInitForServices(Profile* profile,
                                             bool go_off_the_record) {
 #if defined(ENABLE_EXTENSIONS)
@@ skipping 327 matching lines @@
           last_non_supervised_profile_path.BaseName().MaybeAsASCII());
       FinishDeletingProfile(profile_to_delete_path);
     }
   }
 }
 #endif
 
 ProfileManagerWithoutInit::ProfileManagerWithoutInit(
     const base::FilePath& user_data_dir) : ProfileManager(user_data_dir) {
 }