Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1268)

Unified Diff: Source/core/rendering/RenderObject.h

Issue 665673004: Move selection invalidation to the invalidation phase (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Updated after Xianzhu's comments. Created 6 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: Source/core/rendering/RenderObject.h
diff --git a/Source/core/rendering/RenderObject.h b/Source/core/rendering/RenderObject.h
index 68bfb614ae26353fb18dd6dc0ecc3f49ddfbc7eb..87e8fb5a04d6436db471d96de35cea8aacfd4559 100644
--- a/Source/core/rendering/RenderObject.h
+++ b/Source/core/rendering/RenderObject.h
@@ -851,7 +851,7 @@ public:
// Invalidate the paint of a specific subrectangle within a given object. The rect |r| is in the object's coordinate space.
void invalidatePaintRectangle(const LayoutRect&) const;
- void invalidateSelectionIfNeeded(const RenderLayerModelObject&);
+ void invalidateSelectionIfNeeded(const RenderLayerModelObject&, PaintInvalidationReason);
// Walk the tree after layout issuing paint invalidations for renderers that have changed or moved, updating bounds that have changed, and clearing paint invalidation state.
virtual void invalidateTreeIfNeeded(const PaintInvalidationState&);
@@ -1194,6 +1194,9 @@ private:
void invalidatePaintIncludingNonCompositingDescendantsInternal(const RenderLayerModelObject* repaintContainer);
+ LayoutRect previousSelectionRectForPaintInvalidation() const;
+ void setPreviousSelectionRectForPaintInvalidation(const LayoutRect&);
+
const RenderLayerModelObject* enclosingCompositedContainer() const;
RenderFlowThread* locateFlowThreadContainingBlock() const;
@@ -1389,7 +1392,7 @@ private:
// Store state between styleWillChange and styleDidChange
static bool s_affectsParentBlock;
- // This stores the paint invalidation rect from the previous layout.
+ // This stores the paint invalidation rect from the previous frame.
LayoutRect m_previousPaintInvalidationRect;
// This stores the position in the paint invalidation backing's coordinate.

Powered by Google App Engine
This is Rietveld 408576698