Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(32)

Issue 665663002: Use scoped_ptr::Pass instead of scoped_ptr::PassAs<T>. (Closed)

Created:
6 years, 2 months ago by dcheng
Modified:
6 years, 2 months ago
CC:
chromium-reviews, lcwu+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git/+/master
Project:
chromium
Visibility:
Public.

Description

Use scoped_ptr::Pass instead of scoped_ptr::PassAs<T>. Cleanup to make future migration to std::move() easier. BUG=423621 Committed: https://crrev.com/0fafb22c98e650b99b0890f4cd1a392030a3ccb8 Cr-Commit-Position: refs/heads/master@{#300392}

Patch Set 1 #

Total comments: 2

Patch Set 2 : Format #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -9 lines) Patch
M chromecast/browser/url_request_context_factory.cc View 1 1 chunk +1 line, -2 lines 0 comments Download
M components/policy/core/common/registry_dict_win.cc View 2 chunks +3 lines, -3 lines 0 comments Download
M device/test/usb_test_gadget_impl.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M jingle/glue/fake_ssl_client_socket_unittest.cc View 1 1 chunk +1 line, -2 lines 0 comments Download

Messages

Total messages: 17 (5 generated)
dcheng
+gunsch for chromecast changes +atwilson for components changes +rockot for device changes +sergeyu for jingle ...
6 years, 2 months ago (2014-10-17 19:56:42 UTC) #2
gunsch
chromecast/ LGTM https://codereview.chromium.org/665663002/diff/1/chromecast/browser/url_request_context_factory.cc File chromecast/browser/url_request_context_factory.cc (right): https://codereview.chromium.org/665663002/diff/1/chromecast/browser/url_request_context_factory.cc#newcode259 chromecast/browser/url_request_context_factory.cc:259: job_factory.Pass(); nit: could be one line now
6 years, 2 months ago (2014-10-17 20:00:56 UTC) #3
dcheng
https://codereview.chromium.org/665663002/diff/1/chromecast/browser/url_request_context_factory.cc File chromecast/browser/url_request_context_factory.cc (right): https://codereview.chromium.org/665663002/diff/1/chromecast/browser/url_request_context_factory.cc#newcode259 chromecast/browser/url_request_context_factory.cc:259: job_factory.Pass(); On 2014/10/17 20:00:56, gunsch wrote: > nit: could ...
6 years, 2 months ago (2014-10-17 20:10:25 UTC) #4
Andrew T Wilson (Slow)
policy/ lgtm
6 years, 2 months ago (2014-10-20 14:20:37 UTC) #5
Ken Rockot(use gerrit already)
lgtm
6 years, 2 months ago (2014-10-20 17:38:59 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/665663002/20001
6 years, 2 months ago (2014-10-20 23:28:37 UTC) #8
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on tryserver.chromium.linux (http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/18815)
6 years, 2 months ago (2014-10-20 23:38:11 UTC) #10
Alpha Left Google
RSLGTM.
6 years, 2 months ago (2014-10-21 00:55:46 UTC) #12
Alpha Left Google
I mean rubber stamp LGTM. :)
6 years, 2 months ago (2014-10-21 00:56:04 UTC) #14
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/665663002/20001
6 years, 2 months ago (2014-10-21 00:58:09 UTC) #15
commit-bot: I haz the power
Committed patchset #2 (id:20001)
6 years, 2 months ago (2014-10-21 01:03:42 UTC) #16
commit-bot: I haz the power
6 years, 2 months ago (2014-10-21 01:04:28 UTC) #17
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/0fafb22c98e650b99b0890f4cd1a392030a3ccb8
Cr-Commit-Position: refs/heads/master@{#300392}

Powered by Google App Engine
This is Rietveld 408576698