git_cl.py - Issue 665653002: Revert of Fix reitveld base URL for googlesource.com repos.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: git_cl.py

Issue 665653002: Revert of Fix reitveld base URL for googlesource.com repos. (Closed) Base URL: https://chromium.googlesource.com/chromium/tools/depot_tools.git/+/master

Patch Set: Created 6 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: git_cl.py

diff --git a/git_cl.py b/git_cl.py

index d920bce889ba31c71fe426b9e639cc00ada42597..4c5f9634c36a91d8c1690e00460286294aceec5d 100755

--- a/git_cl.py

+++ b/git_cl.py

@@ -1698,13 +1698,9 @@

if ': ' in line)

remote_url = keys.get('URL', None)

else:

- remote = cl.GetRemoteUrl()

- branch = cl.GetUpstreamBranch()

- if remote and branch:

- if 'googlesource' in remote:

- remote_url = remote + '/+/' + branch.split('/')[-1]

- else:

- remote_url = remote + '@' + branch.split('/')[-1]

+ if cl.GetRemoteUrl() and '/' in cl.GetUpstreamBranch():

+ remote_url = (cl.GetRemoteUrl() + '@'

+ + cl.GetUpstreamBranch().split('/')[-1])

if remote_url:

upload_args.extend(['--base_url', remote_url])

« no previous file with comments | « no previous file | no next file » | no next file with comments »