Compile braille ime among other compiled js resources.

Compile braille ime among other compiled js resources.

This includes the braille IME in the compiled js resources.  As a cleanup,
most of the braille IME externs are removed, consolidating with the
central location in third_party/closure_compiler.  The compiler
used for checking braille IME and chroemvox in the presubmit scripts is
chagned to the one in top-level third_party, isntead of the one
in blink.

R=dtseng, tbreisacher
BUG=

Committed: https://crrev.com/d6c36e32a81f912a3722238444c27fc6dd5d7bb8
Cr-Commit-Position: refs/heads/master@{#301327}

[Peter Lundblad, 2014-10-17 16:03:07]

Another cl will add chromevox to the compiled_resources gyp file as well. I'll
then see if we can use that for our presubmit checking as well.

[Dan Beam, 2014-10-17 22:08:43]

dbeam@chromium.org changed reviewers:
+ dbeam@chromium.org

[Dan Beam, 2014-10-17 22:08:44]

https://codereview.chromium.org/665633002/diff/1/third_party/closure_compiler...
File third_party/closure_compiler/compiled_resources.gyp (right):

https://codereview.chromium.org/665633002/diff/1/third_party/closure_compiler...
third_party/closure_compiler/compiled_resources.gyp:11:
'../../chrome/browser/resources/chromeos/braille_ime/compiled_resources.gyp:*',
hey Peter, can you add this file to the CL?

https://codereview.chromium.org/665633002/diff/1/third_party/closure_compiler...
File third_party/closure_compiler/externs/chrome_extensions.js (right):

https://codereview.chromium.org/665633002/diff/1/third_party/closure_compiler...
third_party/closure_compiler/externs/chrome_extensions.js:5270:
ChromeKeyboardEvent.prototype.code;
I don't see this in the internal version of this file.

We update this file via third_party/closure_compiler/bump_compiler_version and
it's likely to just get overwritten if it's not in that file.

[Peter Lundblad, 2014-10-20 08:33:35]

PTAL

dbeam@chromium.org writes:
> 
>
https://codereview.chromium.org/665633002/diff/1/third_party/closure_compiler...
> File third_party/closure_compiler/compiled_resources.gyp (right):
> 
>
https://codereview.chromium.org/665633002/diff/1/third_party/closure_compiler...
> third_party/closure_compiler/compiled_resources.gyp:11:
>
'../../chrome/browser/resources/chromeos/braille_ime/compiled_resources.gyp:*',
> hey Peter, can you add this file to the CL?

Apologies, done.

>
https://codereview.chromium.org/665633002/diff/1/third_party/closure_compiler...
> File third_party/closure_compiler/externs/chrome_extensions.js (right):
> 
>
https://codereview.chromium.org/665633002/diff/1/third_party/closure_compiler...
> third_party/closure_compiler/externs/chrome_extensions.js:5270:
> ChromeKeyboardEvent.prototype.code;
> I don't see this in the internal version of this file.
> 
> We update this file via
> third_party/closure_compiler/bump_compiler_version and it's likely to
> just get overwritten if it's not in that file.

Oh, I missed that that file was updated from closure compiler
sources.  I saw you started adding the externs, so I undid this change
for now, leaving those  two fields in braille_ime's own externs file.
Left a TODO to clean up later.

> https://codereview.chromium.org/665633002/

-- 

To unsubscribe from this group and stop receiving emails from it, send an email
to chromium-reviews+unsubscribe@chromium.org.

[Tyler Breisacher (Chromium), 2014-10-20 16:33:27]

tbreisacher@chromium.org changed reviewers:
+ tbreisacher@chromium.org

[Tyler Breisacher (Chromium), 2014-10-20 16:33:29]

Woohoo! Yay for compiling more JS :)

https://codereview.chromium.org/665633002/diff/40001/chrome/browser/resources...
File chrome/browser/resources/chromeos/chromevox/chromevox/injected/externs.js
(right):

https://codereview.chromium.org/665633002/diff/40001/chrome/browser/resources...
chrome/browser/resources/chromeos/chromevox/chromevox/injected/externs.js:10:
document.webkitHidden;
Perhaps not in this CL, but the unprefixed "document.hidden" works in Chrome,
and is in the default externs at
https://github.com/google/closure-compiler/blob/master/externs/html5.js#L1135,
so you could probably get rid of this.

[Tyler Breisacher (Chromium), 2014-10-20 16:48:18]

tbreisacher@chromium.org changed reviewers:
- tbreisacher@google.com

[Tyler Breisacher (Chromium), 2014-10-20 16:48:18]

lgtm if it also lgt others.

[David Tseng, 2014-10-24 17:34:46]

LGTM

On Mon 20 Oct 2014 09:48:18 AM PDT, tbreisacher@chromium.org wrote:

 > lgtm if it also lgt others.
 > 
 > https://codereview.chromium.org/665633002/
 > 

To unsubscribe from this group and stop receiving emails from it, send an email
to chromium-reviews+unsubscribe@chromium.org.

[Dan Beam, 2014-10-24 17:37:39]

lgtm but check_braille_ime.py doesn't seem necessary anymore as you can do:

  $ gyp --depth $SRC_ROOT third_party/closure_compiler/compiled_resources.gyp
  $ ninja -C out/Default

to compile your code now

[Dan Beam, 2014-10-24 18:40:21]

On 2014/10/24 17:37:39, Dan Beam wrote:
> lgtm but check_braille_ime.py doesn't seem necessary anymore as you can do:
> 
>   $ gyp --depth $SRC_ROOT third_party/closure_compiler/compiled_resources.gyp
>   $ ninja -C out/Default
> 
> to compile your code now

well, this does the _typechecking_ but doesn't store the compiled output
currently (if that's what you want).

your code will also be compiled on each build here:
http://build.chromium.org/p/chromium.fyi/builders/Closure%20Compilation%20Linux

(I'm in the process of fixing the build right now)

[Peter Lundblad, 2014-10-27 08:19:36]

The CQ bit was checked by plundblad@chromium.org

[commit-bot: I haz the power, 2014-10-27 08:19:52]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/665633002/60001

[Peter Lundblad, 2014-10-27 08:23:46]

dbeam@chromium.org writes:
> lgtm but check_braille_ime.py doesn't seem necessary anymore as you can do:
> 
>    $ gyp --depth $SRC_ROOT  
> third_party/closure_compiler/compiled_resources.gyp
>    $ ninja -C out/Default
> 
> to compile your code now

Yes, that's true.  check_braille_ime.py is currently used in the
presubmit script.  Do you think it is wise to put the
eqivalent of the above code in a presubmit script?

Thanks,
//Peter

> https://codereview.chromium.org/665633002/

-- 

To unsubscribe from this group and stop receiving emails from it, send an email
to chromium-reviews+unsubscribe@chromium.org.

[commit-bot: I haz the power, 2014-10-27 09:06:01]

Committed patchset #4 (id:60001)

[commit-bot: I haz the power, 2014-10-27 09:06:52]

Patchset 4 (id:??) landed as
https://crrev.com/d6c36e32a81f912a3722238444c27fc6dd5d7bb8
Cr-Commit-Position: refs/heads/master@{#301327}

[Dan Beam, 2014-10-29 01:43:25]

On 2014/10/27 08:23:46, Peter Lundblad wrote:
> mailto:dbeam@chromium.org writes:
> > lgtm but check_braille_ime.py doesn't seem necessary anymore as you can do:
> > 
> >    $ gyp --depth $SRC_ROOT  
> > third_party/closure_compiler/compiled_resources.gyp
> >    $ ninja -C out/Default
> > 
> > to compile your code now
> 
> Yes, that's true.  check_braille_ime.py is currently used in the
> presubmit script.  Do you think it is wise to put the
> eqivalent of the above code in a presubmit script?

uh, probably not yet.  we are working on a global presubmit in the future,
though.

> 
> Thanks,
> //Peter
> 
> > https://codereview.chromium.org/665633002/
> 
> -- 
> 
> To unsubscribe from this group and stop receiving emails from it, send an
email
> to mailto:chromium-reviews+unsubscribe@chromium.org.