Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(134)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 665613003: Remove the ability to parse HTML fragments (Closed)

Created:
6 years, 2 months ago by abarth-chromium
Modified:
6 years, 1 month ago
Reviewers:
eseidel, esprehn, ojan
CC:
ojan, esprehn, mojo-reviews_chromium.org, rafaelw
Base URL:
git@github.com:domokit/mojo.git@master
Project:
mojo
Visibility:
Public.

Description

Remove the ability to parse HTML fragments Also, removed a bunch of show() function from the custom element microtask queue that bottom out in innerHTML. R=eseidel@chromium.org Committed: https://chromium.googlesource.com/external/mojo/+/44380674b0c222c980f5fdaa73b9a76ca0259570

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -332 lines) Patch
M sky/engine/core/dom/DocumentFragment.h View 1 chunk +0 lines, -2 lines 0 comments Download
M sky/engine/core/dom/DocumentFragment.cpp View 1 chunk +0 lines, -5 lines 0 comments Download
M sky/engine/core/dom/Element.h View 1 chunk +0 lines, -4 lines 0 comments Download
M sky/engine/core/dom/Element.cpp View 1 chunk +0 lines, -49 lines 0 comments Download
M sky/engine/core/dom/custom/CustomElementMicrotaskImportStep.h View 1 chunk +0 lines, -3 lines 0 comments Download
M sky/engine/core/dom/custom/CustomElementMicrotaskImportStep.cpp View 1 chunk +0 lines, -8 lines 0 comments Download
M sky/engine/core/dom/custom/CustomElementMicrotaskQueueBase.h View 1 chunk +0 lines, -4 lines 0 comments Download
M sky/engine/core/dom/custom/CustomElementMicrotaskQueueBase.cpp View 1 chunk +0 lines, -12 lines 0 comments Download
M sky/engine/core/dom/custom/CustomElementMicrotaskResolutionStep.h View 1 chunk +0 lines, -4 lines 0 comments Download
M sky/engine/core/dom/custom/CustomElementMicrotaskResolutionStep.cpp View 1 chunk +0 lines, -8 lines 0 comments Download
M sky/engine/core/dom/custom/CustomElementMicrotaskRunQueue.h View 1 chunk +0 lines, -4 lines 0 comments Download
M sky/engine/core/dom/custom/CustomElementMicrotaskRunQueue.cpp View 1 chunk +0 lines, -10 lines 0 comments Download
M sky/engine/core/dom/custom/CustomElementMicrotaskStep.h View 1 chunk +0 lines, -4 lines 0 comments Download
M sky/engine/core/dom/shadow/ShadowRoot.h View 1 chunk +0 lines, -3 lines 0 comments Download
M sky/engine/core/dom/shadow/ShadowRoot.cpp View 1 chunk +0 lines, -16 lines 0 comments Download
M sky/engine/core/dom/shadow/ShadowRoot.idl View 1 chunk +0 lines, -2 lines 0 comments Download
M sky/engine/core/editing/CompositeEditCommand.cpp View 1 chunk +0 lines, -110 lines 2 comments Download
M sky/engine/core/editing/markup.h View 1 chunk +0 lines, -3 lines 0 comments Download
M sky/engine/core/editing/markup.cpp View 2 chunks +0 lines, -16 lines 0 comments Download
M sky/engine/core/html/HTMLElement.cpp View 1 chunk +0 lines, -11 lines 0 comments Download
M sky/engine/core/html/parser/HTMLDocumentParser.h View 3 chunks +0 lines, -9 lines 0 comments Download
M sky/engine/core/html/parser/HTMLDocumentParser.cpp View 4 chunks +0 lines, -45 lines 0 comments Download

Messages

Total messages: 9 (2 generated)
abarth-chromium
6 years, 2 months ago (2014-10-24 22:46:00 UTC) #1
eseidel
lgtm https://codereview.chromium.org/665613003/diff/1/sky/engine/core/editing/CompositeEditCommand.cpp File sky/engine/core/editing/CompositeEditCommand.cpp (left): https://codereview.chromium.org/665613003/diff/1/sky/engine/core/editing/CompositeEditCommand.cpp#oldcode972 sky/engine/core/editing/CompositeEditCommand.cpp:972: void CompositeEditCommand::moveParagraphs(const VisiblePosition& startOfParagraphToMove, const VisiblePosition& endOfParagraphToMove, const ...
6 years, 2 months ago (2014-10-24 22:48:21 UTC) #2
esprehn
https://codereview.chromium.org/665613003/diff/1/sky/engine/core/editing/CompositeEditCommand.cpp File sky/engine/core/editing/CompositeEditCommand.cpp (right): https://codereview.chromium.org/665613003/diff/1/sky/engine/core/editing/CompositeEditCommand.cpp#newcode973 sky/engine/core/editing/CompositeEditCommand.cpp:973: { Can you add a FIXME or something? Just ...
6 years, 2 months ago (2014-10-24 22:52:07 UTC) #4
abarth-chromium
On 2014/10/24 at 22:52:07, esprehn wrote: > https://codereview.chromium.org/665613003/diff/1/sky/engine/core/editing/CompositeEditCommand.cpp > File sky/engine/core/editing/CompositeEditCommand.cpp (right): > > https://codereview.chromium.org/665613003/diff/1/sky/engine/core/editing/CompositeEditCommand.cpp#newcode973 ...
6 years, 2 months ago (2014-10-24 23:10:49 UTC) #5
abarth-chromium
Committed patchset #1 (id:1) manually as 44380674b0c222c980f5fdaa73b9a76ca0259570 (presubmit successful).
6 years, 2 months ago (2014-10-24 23:51:15 UTC) #6
ojan
Are we giving up on waiting until raf has the demo app running before breaking ...
6 years, 1 month ago (2014-10-25 17:15:15 UTC) #8
abarth-chromium
6 years, 1 month ago (2014-10-25 17:55:31 UTC) #9
Message was sent while issue was closed. 
On 2014/10/25 at 17:15:15, ojan wrote:
> Are we giving up on waiting until raf has the demo app running before breaking
things on him again?

You're talking about the change to ShadowRoot.idl?  We already removed the IDL
for innerHTML everywhere else.

Powered by Google App Engine
This is Rietveld 408576698