Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(137)

Issue 665613002: Move /fetch to use C++11 (Closed)

Created:
6 years, 2 months ago by kenneth.r.christiansen
Modified:
6 years, 2 months ago
Reviewers:
Mike West
CC:
blink-reviews, gavinp+loader_chromium.org, Nate Chapin
Project:
blink
Visibility:
Public.

Description

Improve C++11 in /fetch Use the actual type in places where it makes the code clearer and not any longer. Fix spelling error. Use nullptr. Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=183964

Patch Set 1 #

Patch Set 2 : Rebased #

Unified diffs Side-by-side diffs Delta from patch set Stats (+23 lines, -25 lines) Patch
M Source/core/fetch/ImageResource.h View 1 1 chunk +1 line, -1 line 0 comments Download
M Source/core/fetch/ImageResource.cpp View 1 3 chunks +3 lines, -3 lines 0 comments Download
M Source/core/fetch/Resource.cpp View 1 4 chunks +7 lines, -9 lines 0 comments Download
M Source/core/fetch/ResourceFetcher.h View 1 1 chunk +1 line, -1 line 0 comments Download
M Source/core/fetch/ResourceFetcher.cpp View 1 9 chunks +11 lines, -11 lines 0 comments Download

Messages

Total messages: 8 (2 generated)
Mike West
On 2014/10/17 16:18:52, kenneth.r.christiansen wrote: > mailto:kenneth.r.christiansen@intel.com changed reviewers: > + mailto:mkwst@chromium.org Sorry! https://codereview.chromium.org/645513003/ came ...
6 years, 2 months ago (2014-10-17 19:15:56 UTC) #2
kenneth.r.christiansen
On 2014/10/17 at 19:15:56, mkwst wrote: > On 2014/10/17 16:18:52, kenneth.r.christiansen wrote: > > mailto:kenneth.r.christiansen@intel.com ...
6 years, 2 months ago (2014-10-18 10:38:02 UTC) #3
kenneth.r.christiansen
> It has additional changes, I will upload a rebased version Done
6 years, 2 months ago (2014-10-18 10:41:06 UTC) #4
Mike West
LGTM, thanks.
6 years, 2 months ago (2014-10-18 11:47:33 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/665613002/20001
6 years, 2 months ago (2014-10-20 06:49:20 UTC) #7
commit-bot: I haz the power
6 years, 2 months ago (2014-10-20 06:53:15 UTC) #8
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as 183964

Powered by Google App Engine
This is Rietveld 408576698