Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(488)

Unified Diff: net/third_party/nss/ssl/ssl3con.c

Issue 66553007: net: don't add padding extension for SSLv3. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 7 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « net/third_party/nss/patches/paddingextension.patch ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: net/third_party/nss/ssl/ssl3con.c
diff --git a/net/third_party/nss/ssl/ssl3con.c b/net/third_party/nss/ssl/ssl3con.c
index 567d481203a4e98a3f43f25cb5fdf091445e7e46..25709b227ebb1889bc620386b510988cc02aa3b1 100644
--- a/net/third_party/nss/ssl/ssl3con.c
+++ b/net/third_party/nss/ssl/ssl3con.c
@@ -5248,7 +5248,9 @@ ssl3_SendClientHello(sslSocket *ss, PRBool resending)
* in F5 devices.
*
* This is not done for DTLS nor for renegotiation. */
- if (!IS_DTLS(ss) && !ss->firstHsDone) {
+ if (!IS_DTLS(ss) &&
+ ss->version > SSL_LIBRARY_VERSION_3_0 &&
wtc 2013/11/11 19:49:53 We can just test the local variable 'isTLS'. (We
agl 2013/11/11 20:23:49 Done.
+ !ss->firstHsDone) {
paddingExtensionLen = ssl3_CalculatePaddingExtensionLength(length);
total_exten_len += paddingExtensionLen;
length += paddingExtensionLen;
« no previous file with comments | « net/third_party/nss/patches/paddingextension.patch ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698