net: don't add padding extension for SSLv3.

net/third_party/nss/ssl/sslimpl.h

 /*
  * This file is PRIVATE to SSL and should be the first thing included by
  * any SSL implementation file.
  *
  * This Source Code Form is subject to the terms of the Mozilla Public
  * License, v. 2.0. If a copy of the MPL was not distributed with this
  * file, You can obtain one at http://mozilla.org/MPL/2.0/. */
 
 #ifndef __sslimpl_h_
 #define __sslimpl_h_
@@ skipping 219 matching lines @@
 } ssl3HelloExtensionHandler;
 
 extern SECStatus 
 ssl3_RegisterServerHelloExtensionSender(sslSocket *ss, PRUint16 ex_type,
                                         ssl3HelloExtensionSenderFunc cb);
 
 extern PRInt32
 ssl3_CallHelloExtensionSenders(sslSocket *ss, PRBool append, PRUint32 maxBytes,
                                const ssl3HelloExtensionSender *sender);
 
-extern unsigned int
+extern PRInt32
 ssl3_CalculatePaddingExtensionLength(unsigned int clientHelloLength);
 
 extern unsigned int
 ssl3_AppendPaddingExtension(sslSocket *ss, unsigned int extensionLen,
                             PRUint32 maxBytes);

[wtc, 2013/11/11 21:50:33]

I may have made a mistake in my previous comment.

It is this function that should return a signed type. The
ssl3_CalculatePaddingExtensionLength function above should continue to return
unsigned int.

 
 /* Socket ops */
 struct sslSocketOpsStr {
     int         (*connect) (sslSocket *, const PRNetAddr *);
     PRFileDesc *(*accept)  (sslSocket *, PRNetAddr *);
     int         (*bind)    (sslSocket *, const PRNetAddr *);
     int         (*listen)  (sslSocket *, int);
     int         (*shutdown)(sslSocket *, int);
     int         (*close)   (sslSocket *);
 
@@ skipping 1693 matching lines @@
 #if defined(XP_UNIX) || defined(XP_OS2) || defined(XP_BEOS)
 #define SSL_GETPID getpid
 #elif defined(WIN32)
 extern int __cdecl _getpid(void);
 #define SSL_GETPID _getpid
 #else
 #define SSL_GETPID() 0
 #endif
 
 #endif /* __sslimpl_h_ */