Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(217)

Issue 665493002: Fix clang-format canned check warning text (Closed)

Created:
6 years, 2 months ago by enne (OOO)
Modified:
6 years, 2 months ago
Reviewers:
Dirk Pranke, iannucci
CC:
chromium-reviews, cmp-cc_chromium.org, Dirk Pranke, iannucci+depot_tools_chromium.org, jbroman, jkarlin
Project:
tools
Visibility:
Public.

Description

Fix clang-format canned check warning text input_api.basename is a function, so printing it out yields: "The <function basename at 0x7fccd3735410> directory requires..>" Instead, use it to resolve the local presubmit path that has requested clang formatting. R=dpranke@chromium.org BUG=422332 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=292491

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -1 line) Patch
M presubmit_canned_checks.py View 1 chunk +3 lines, -1 line 0 comments Download

Messages

Total messages: 6 (2 generated)
enne (OOO)
6 years, 2 months ago (2014-10-16 19:04:08 UTC) #1
iannucci
lol, lgtm
6 years, 2 months ago (2014-10-16 19:19:01 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/665493002/1
6 years, 2 months ago (2014-10-16 19:20:50 UTC) #5
commit-bot: I haz the power
6 years, 2 months ago (2014-10-16 19:23:08 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 (id:1) as 292491

Powered by Google App Engine
This is Rietveld 408576698