Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(281)

Issue 665483002: SafeSPrintf: use C++ variadic template (Closed)

Created:
6 years, 2 months ago by jln (very slow on Chromium)
Modified:
6 years, 2 months ago
Reviewers:
Lei Zhang, mdempsky
CC:
chromium-reviews, erikwright+watch_chromium.org, jshin+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

SafeSPrintf: use C++ variadic template Revert 543be0953e1ea908c2b5bbc005af3f3d61eb09f1 and always use C++11 variadic template. Also add mdempsky@ and jln@ as owners. Committed: https://crrev.com/ad396f7c3ba3253b0376088c2f11c59e9f4eac96 Cr-Commit-Position: refs/heads/master@{#299977}

Patch Set 1 : #

Patch Set 2 : Use sizeof... #

Unified diffs Side-by-side diffs Delta from patch set Stats (+17 lines, -209 lines) Patch
M base/strings/OWNERS View 1 chunk +2 lines, -1 line 0 comments Download
M base/strings/safe_sprintf.h View 1 1 chunk +8 lines, -208 lines 0 comments Download
M base/strings/safe_sprintf_unittest.cc View 1 chunk +7 lines, -0 lines 0 comments Download

Messages

Total messages: 12 (5 generated)
jln (very slow on Chromium)
Matthew: PTAL!
6 years, 2 months ago (2014-10-16 19:07:08 UTC) #4
mdempsky
lgtm
6 years, 2 months ago (2014-10-16 19:11:54 UTC) #5
jln (very slow on Chromium)
Lei: could you please approve the owner change? Replacing Markus by mdempsky and myself.
6 years, 2 months ago (2014-10-16 19:15:07 UTC) #7
Lei Zhang
lgtm Ahhh, much better.
6 years, 2 months ago (2014-10-16 20:49:42 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/665483002/60001
6 years, 2 months ago (2014-10-16 21:07:22 UTC) #10
commit-bot: I haz the power
Committed patchset #2 (id:60001)
6 years, 2 months ago (2014-10-16 21:24:57 UTC) #11
commit-bot: I haz the power
6 years, 2 months ago (2014-10-16 21:25:51 UTC) #12
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/ad396f7c3ba3253b0376088c2f11c59e9f4eac96
Cr-Commit-Position: refs/heads/master@{#299977}

Powered by Google App Engine
This is Rietveld 408576698