Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2471)

Unified Diff: cc/test/test_gpu_memory_buffer_manager.cc

Issue 665463003: gpu: Add CHROMIUM_image support to in-process command buffer. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@move-gpu-memory-buffer-factory-to-gpu-image-factory
Patch Set: make code more consistent with command buffer proxy Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: cc/test/test_gpu_memory_buffer_manager.cc
diff --git a/cc/test/test_gpu_memory_buffer_manager.cc b/cc/test/test_gpu_memory_buffer_manager.cc
index 855959e8d08a6a43b032669e067ba2eaf7f703dc..d055ad6f95531bd2818b303903eacfaf15811e72 100644
--- a/cc/test/test_gpu_memory_buffer_manager.cc
+++ b/cc/test/test_gpu_memory_buffer_manager.cc
@@ -10,22 +10,39 @@
namespace cc {
namespace {
+size_t BytesPerPixel(gfx::GpuMemoryBuffer::Format format) {
+ switch (format) {
+ case gfx::GpuMemoryBuffer::RGBA_8888:
+ case gfx::GpuMemoryBuffer::RGBX_8888:
+ case gfx::GpuMemoryBuffer::BGRA_8888:
+ return 4;
+ }
+
+ NOTREACHED();
+ return 0;
+}
+
class GpuMemoryBufferImpl : public gfx::GpuMemoryBuffer {
public:
- GpuMemoryBufferImpl(const gfx::Size& size, Format format)
+ GpuMemoryBufferImpl(const gfx::Size& size,
+ Format format,
+ scoped_ptr<base::SharedMemory> shared_memory)
: size_(size),
format_(format),
- pixels_(new uint8[size.GetArea() * BytesPerPixel(format)]),
+ shared_memory_(shared_memory.Pass()),
mapped_(false) {}
// Overridden from gfx::GpuMemoryBuffer:
virtual void* Map() override {
DCHECK(!mapped_);
+ if (!shared_memory_->Map(size_.GetArea() * BytesPerPixel(format_)))
+ return NULL;
mapped_ = true;
- return pixels_.get();
+ return shared_memory_->memory();
}
virtual void Unmap() override {
DCHECK(mapped_);
+ shared_memory_->Unmap();
mapped_ = false;
}
virtual bool IsMapped() const override { return mapped_; }
@@ -34,29 +51,19 @@ class GpuMemoryBufferImpl : public gfx::GpuMemoryBuffer {
return size_.width() * BytesPerPixel(format_);
}
virtual gfx::GpuMemoryBufferHandle GetHandle() const override {
- NOTREACHED();
- return gfx::GpuMemoryBufferHandle();
+ gfx::GpuMemoryBufferHandle handle;
+ handle.type = gfx::SHARED_MEMORY_BUFFER;
+ handle.handle = shared_memory_->handle();
+ return handle;
}
virtual ClientBuffer AsClientBuffer() override {
return reinterpret_cast<ClientBuffer>(this);
}
private:
- static size_t BytesPerPixel(Format format) {
- switch (format) {
- case RGBA_8888:
- case RGBX_8888:
- case BGRA_8888:
- return 4;
- }
-
- NOTREACHED();
- return 0;
- }
-
const gfx::Size size_;
no sievers 2014/10/17 21:16:50 nit: could make size_ and format_ const since bad
reveman 2014/10/17 22:36:17 Done.
gfx::GpuMemoryBuffer::Format format_;
- scoped_ptr<uint8[]> pixels_;
+ scoped_ptr<base::SharedMemory> shared_memory_;
bool mapped_;
};
@@ -73,8 +80,11 @@ TestGpuMemoryBufferManager::AllocateGpuMemoryBuffer(
const gfx::Size& size,
gfx::GpuMemoryBuffer::Format format,
gfx::GpuMemoryBuffer::Usage usage) {
+ scoped_ptr<base::SharedMemory> shared_memory(new base::SharedMemory);
+ if (!shared_memory->CreateAnonymous(size.GetArea() * BytesPerPixel(format)))
+ return nullptr;
return make_scoped_ptr<gfx::GpuMemoryBuffer>(
- new GpuMemoryBufferImpl(size, format));
+ new GpuMemoryBufferImpl(size, format, shared_memory.Pass()));
}
gfx::GpuMemoryBuffer*
« no previous file with comments | « cc/test/DEPS ('k') | cc/test/test_image_factory.h » ('j') | cc/test/test_image_factory.h » ('J')

Powered by Google App Engine
This is Rietveld 408576698