Issue 665423003: DevTools: initial support of box selection on FlameChart

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 665423003: DevTools: initial support of box selection on FlameChart (Closed)

Created:
6 years, 2 months ago by yurys

Modified:
6 years, 2 months ago

Reviewers:
caseq, pfeldman, loislo

CC:
blink-reviews, caseq+blink_chromium.org, loislo+blink_chromium.org, eustas+blink_chromium.org, malch+blink_chromium.org, yurys+blink_chromium.org, lushnikov+blink_chromium.org, vsevik+blink_chromium.org, pfeldman+blink_chromium.org, paulirish+reviews_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, sergeyv+blink_chromium.org, aandrey+blink_chromium.org

Base URL:
svn://svn.chromium.org/blink/trunk

Project:
blink

Visibility:
Public.

More Reviews

Description

DevTools: initial support of box selection on FlameChart If shift is held when dragging starts on the flame chart rectangle selection box will be drawn for the selected region. Selected range duration will be printed at the left top corner of the rectangle with precision of 0.01 ms. BUG=407113 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=184194

Patch Set 1 #

Patch Set 2 : Fixed typo #

Created: 6 years, 2 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+75 lines, -0 lines)			Patch
	M	Source/devtools/front_end/components/FlameChart.js	View	1	4 chunks	+61 lines, -0 lines	0 comments	Download
	M	Source/devtools/front_end/components/flameChart.css	View	1	1 chunk	+14 lines, -0 lines	0 comments	Download

Messages

Total messages: 6 (2 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/665423003/20001

6 years, 2 months ago (2014-10-22 14:10:36 UTC) #5

commit-bot: I haz the power

6 years, 2 months ago (2014-10-22 16:01:11 UTC) #6

Message was sent while issue was closed.

Committed patchset #2 (id:20001) as 184194

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages