Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(141)

Issue 665423002: cc: Disable low res in non-smoothness mode. (Closed)

Created:
6 years, 2 months ago by vmpstr
Modified:
6 years, 2 months ago
Reviewers:
danakj, reveman
CC:
chromium-reviews, cc-bugs_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

cc: Disable low res in non-smoothness mode. This patch ensures that we don't rasterize low res tiles unless we're in smoothness mode. The reasoning is that the visible area that is going to be covered already will have high res tiles returned for rasterization, so we don't need to bother with low res. Once a smoothness mode is entered, we will first rasterize low res tiles, followed by high res tiles. R=reveman Committed: https://crrev.com/27730bed93e15aefc18dbe52412c2d6302ab7e76 Cr-Commit-Position: refs/heads/master@{#300699}

Patch Set 1 #

Patch Set 2 : test fixes #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+29 lines, -18 lines) Patch
M cc/layers/picture_layer_impl.cc View 1 chunk +1 line, -1 line 0 comments Download
M cc/layers/picture_layer_impl_unittest.cc View 1 4 chunks +4 lines, -5 lines 2 comments Download
M cc/resources/tile_manager_unittest.cc View 1 11 chunks +24 lines, -12 lines 0 comments Download

Messages

Total messages: 10 (2 generated)
vmpstr
PTAL
6 years, 2 months ago (2014-10-21 21:54:56 UTC) #1
vmpstr
... now with test fixes
6 years, 2 months ago (2014-10-21 22:17:31 UTC) #2
reveman
lgtm
6 years, 2 months ago (2014-10-22 02:26:04 UTC) #3
danakj
https://codereview.chromium.org/665423002/diff/20001/cc/layers/picture_layer_impl_unittest.cc File cc/layers/picture_layer_impl_unittest.cc (right): https://codereview.chromium.org/665423002/diff/20001/cc/layers/picture_layer_impl_unittest.cc#newcode3796 cc/layers/picture_layer_impl_unittest.cc:3796: EXPECT_EQ(unoccluded_tile_count, 25); LGTM if there's still a test somewhere ...
6 years, 2 months ago (2014-10-22 14:27:40 UTC) #5
vmpstr
https://codereview.chromium.org/665423002/diff/20001/cc/layers/picture_layer_impl_unittest.cc File cc/layers/picture_layer_impl_unittest.cc (right): https://codereview.chromium.org/665423002/diff/20001/cc/layers/picture_layer_impl_unittest.cc#newcode3796 cc/layers/picture_layer_impl_unittest.cc:3796: EXPECT_EQ(unoccluded_tile_count, 25); On 2014/10/22 14:27:40, danakj wrote: > LGTM ...
6 years, 2 months ago (2014-10-22 14:40:17 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/665423002/20001
6 years, 2 months ago (2014-10-22 14:41:03 UTC) #8
commit-bot: I haz the power
Committed patchset #2 (id:20001)
6 years, 2 months ago (2014-10-22 17:47:02 UTC) #9
commit-bot: I haz the power
6 years, 2 months ago (2014-10-22 17:47:34 UTC) #10
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/27730bed93e15aefc18dbe52412c2d6302ab7e76
Cr-Commit-Position: refs/heads/master@{#300699}

Powered by Google App Engine
This is Rietveld 408576698