Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(39)

Issue 665373005: Standardize usage of virtual/override/final in skia/ (Closed)

Created:
6 years, 2 months ago by dcheng
Modified:
6 years, 2 months ago
Reviewers:
Justin Novosad
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Standardize usage of virtual/override/final in skia/ The Google C++ style guide states: Explicitly annotate overrides of virtual functions or virtual destructors with an override or (less frequently) final specifier. Older (pre-C++11) code will use the virtual keyword as an inferior alternative annotation. For clarity, use exactly one of override, final, or virtual when declaring an override. To better conform to these guidelines, the following constructs have been rewritten: - if a base class has a virtual destructor, then: virtual ~Foo(); -> ~Foo() override; - virtual void Foo() override; -> void Foo() override; - virtual void Foo() override final; -> void Foo() final; This patch was automatically generated. The clang plugin can generate fixit hints, which are suggested edits when it is 100% sure it knows how to fix a problem. The hints from the clang plugin were applied to the source tree using the tool in https://codereview.chromium.org/598073004. BUG=417463 R=junov@chromium.org Committed: https://crrev.com/9f927559a6cb793f8f4a23160a9b2df5254f4dba Cr-Commit-Position: refs/heads/master@{#300701}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+283 lines, -263 lines) Patch
M skia/ext/SkDiscardableMemory_chrome.h View 1 chunk +4 lines, -4 lines 0 comments Download
M skia/ext/analysis_canvas.h View 2 chunks +84 lines, -83 lines 0 comments Download
M skia/ext/benchmarking_canvas.h View 1 chunk +1 line, -1 line 0 comments Download
M skia/ext/benchmarking_canvas.cc View 2 chunks +73 lines, -51 lines 0 comments Download
M skia/ext/bitmap_platform_device_mac.h View 1 chunk +10 lines, -8 lines 0 comments Download
M skia/ext/event_tracer_impl.cc View 1 chunk +14 lines, -17 lines 0 comments Download
M skia/ext/lazy_pixel_ref.h View 1 chunk +1 line, -1 line 0 comments Download
M skia/ext/opacity_draw_filter.h View 1 chunk +2 lines, -2 lines 0 comments Download
M skia/ext/pixel_ref_utils.cc View 10 chunks +80 lines, -80 lines 0 comments Download
M skia/ext/pixel_ref_utils_unittest.cc View 1 chunk +5 lines, -7 lines 0 comments Download
M skia/ext/vector_platform_device_skia.h View 1 chunk +9 lines, -9 lines 0 comments Download

Messages

Total messages: 6 (1 generated)
dcheng
6 years, 2 months ago (2014-10-21 20:53:25 UTC) #1
Justin Novosad
On 2014/10/21 20:53:25, dcheng wrote: lgtm
6 years, 2 months ago (2014-10-22 14:32:27 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/665373005/1
6 years, 2 months ago (2014-10-22 16:24:50 UTC) #4
commit-bot: I haz the power
Committed patchset #1 (id:1)
6 years, 2 months ago (2014-10-22 17:57:05 UTC) #5
commit-bot: I haz the power
6 years, 2 months ago (2014-10-22 17:58:09 UTC) #6
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/9f927559a6cb793f8f4a23160a9b2df5254f4dba
Cr-Commit-Position: refs/heads/master@{#300701}

Powered by Google App Engine
This is Rietveld 408576698