Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(180)

Issue 665353002: Add AudioDirectiveHandler timed tests. (Closed)

Created:
6 years, 2 months ago by rkc
Modified:
6 years, 1 month ago
Reviewers:
xiyuan
CC:
chromium-reviews, erikwright+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@audio_redesign
Project:
chromium
Visibility:
Public.

Description

Add AudioDirectiveHandler timed tests. This CL adds tests for AudioDirectiveHandler which move time forward to verify functionality. It also adds a ref counted tick clock proxy that can be used to pass around a tick clock among multiple classes. BUG=None. R=xiyuan@chromium.org Committed: https://crrev.com/48d872c84c0b1a6d74b3fd0fa6e04673d787d247 Cr-Commit-Position: refs/heads/master@{#301400}

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : #

Total comments: 10

Patch Set 4 : #

Patch Set 5 : merge #

Patch Set 6 : merge. #

Patch Set 7 : build fix. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+171 lines, -11 lines) Patch
M components/copresence.gypi View 1 2 3 4 1 chunk +2 lines, -0 lines 0 comments Download
M components/copresence/BUILD.gn View 1 2 3 4 1 chunk +2 lines, -0 lines 0 comments Download
M components/copresence/handlers/audio/audio_directive_handler.h View 1 2 3 4 5 4 chunks +6 lines, -2 lines 0 comments Download
M components/copresence/handlers/audio/audio_directive_handler.cc View 1 2 3 4 5 3 chunks +19 lines, -1 line 0 comments Download
M components/copresence/handlers/audio/audio_directive_handler_unittest.cc View 1 2 3 4 5 2 chunks +67 lines, -1 line 0 comments Download
M components/copresence/handlers/audio/audio_directive_list.h View 1 2 3 4 3 chunks +6 lines, -5 lines 0 comments Download
M components/copresence/handlers/audio/audio_directive_list.cc View 1 2 3 3 chunks +11 lines, -2 lines 0 comments Download
A components/copresence/handlers/audio/tick_clock_ref_counted.h View 1 2 3 4 5 6 1 chunk +36 lines, -0 lines 0 comments Download
A components/copresence/handlers/audio/tick_clock_ref_counted.cc View 1 2 3 1 chunk +22 lines, -0 lines 0 comments Download

Messages

Total messages: 16 (6 generated)
rkc
Added xiyuan@ as a reviewer. I'll land this CL at least while https://codereview.chromium.org/670623002/ goes through ...
6 years, 2 months ago (2014-10-21 19:00:36 UTC) #2
xiyuan
lgtm https://codereview.chromium.org/665353002/diff/40001/components/copresence/handlers/audio/tick_clock_ref_counted.h File components/copresence/handlers/audio/tick_clock_ref_counted.h (right): https://codereview.chromium.org/665353002/diff/40001/components/copresence/handlers/audio/tick_clock_ref_counted.h#newcode9 components/copresence/handlers/audio/tick_clock_ref_counted.h:9: #include <vector> nit: both headers seems not used. ...
6 years, 2 months ago (2014-10-21 21:08:13 UTC) #3
rkc
https://codereview.chromium.org/665353002/diff/40001/components/copresence/handlers/audio/tick_clock_ref_counted.h File components/copresence/handlers/audio/tick_clock_ref_counted.h (right): https://codereview.chromium.org/665353002/diff/40001/components/copresence/handlers/audio/tick_clock_ref_counted.h#newcode9 components/copresence/handlers/audio/tick_clock_ref_counted.h:9: #include <vector> On 2014/10/21 21:08:12, xiyuan wrote: > nit: ...
6 years, 2 months ago (2014-10-22 00:16:58 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/665353002/80001
6 years, 2 months ago (2014-10-23 04:39:30 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: linux_gpu on tryserver.chromium.gpu (http://build.chromium.org/p/tryserver.chromium.gpu/builders/linux_gpu/builds/82747) mac_gpu on tryserver.chromium.gpu (http://build.chromium.org/p/tryserver.chromium.gpu/builders/mac_gpu/builds/72393) win_gpu ...
6 years, 2 months ago (2014-10-23 04:43:05 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/665353002/100001
6 years, 1 month ago (2014-10-27 15:19:47 UTC) #10
commit-bot: I haz the power
Try jobs failed on following builders: win_gpu on tryserver.chromium.gpu (http://build.chromium.org/p/tryserver.chromium.gpu/builders/win_gpu/builds/78895)
6 years, 1 month ago (2014-10-27 15:53:32 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/665353002/120001
6 years, 1 month ago (2014-10-27 17:26:31 UTC) #14
commit-bot: I haz the power
Committed patchset #7 (id:120001)
6 years, 1 month ago (2014-10-27 18:12:43 UTC) #15
commit-bot: I haz the power
6 years, 1 month ago (2014-10-27 18:13:30 UTC) #16
Message was sent while issue was closed.
Patchset 7 (id:??) landed as
https://crrev.com/48d872c84c0b1a6d74b3fd0fa6e04673d787d247
Cr-Commit-Position: refs/heads/master@{#301400}

Powered by Google App Engine
This is Rietveld 408576698