Move KeySystemInfo to media.

Move KeySystemInfo to media/.

This is a preparation to move KeySystems to media, which is needed to support
Encrypted Media Extensions (EME) without relying on content.

BUG=422730
Committed: https://crrev.com/1c03e830f2ab2d83e2bdc96cb399d2a43c77f576
Cr-Commit-Position: refs/heads/master@{#300992}

[xhwang, 2014-10-21 17:20:00]

xhwang@chromium.org changed reviewers:
+ boliu@chromium.org

[xhwang, 2014-10-21 17:21:12]

xhwang@chromium.org changed reviewers:
+ gunsch@chromium.org

[xhwang, 2014-10-21 17:23:15]

xhwang@chromium.org changed reviewers:
+ jam@chromium.org

[xhwang, 2014-10-21 17:23:41]

xhwang@chromium.org changed reviewers:
+ dcheng@chromium.org

[xhwang, 2014-10-21 17:23:59]

xhwang@chromium.org changed reviewers:
+ ddorwin@chromium.org

[xhwang, 2014-10-22 00:00:19]

Patchset #2 (id:20001) has been deleted

[xhwang, 2014-10-22 00:00:28]

Patchset #2 (id:40001) has been deleted

[xhwang, 2014-10-22 00:00:39]

Patchset #1 (id:1) has been deleted

[xhwang, 2014-10-22 00:00:47]

Patchset #1 (id:60001) has been deleted

[gunsch, 2014-10-22 03:43:10]

chromecast/ LGTM

[xhwang, 2014-10-22 07:00:08]

xhwang@chromium.org changed required reviewers:
+ ddorwin@chromium.org, jam@chromium.org

[xhwang, 2014-10-22 07:00:09]

jam: Please OWNERS review content/public/* and chrome/renderer/*. Please see the
comment/question I had.

ddorwin: Please review the whole CL. But you probably want to wait until jam@'s
approval.

gunsch/boliu/dcheng: I'll need your OWNER's stamp later after I get
jam/ddorwin's approval.

https://codereview.chromium.org/665343002/diff/80001/content/public/renderer/...
File content/public/renderer/content_renderer_client.h (right):

https://codereview.chromium.org/665343002/diff/80001/content/public/renderer/...
content/public/renderer/content_renderer_client.h:249: virtual void
AddKeySystems(std::vector<media::KeySystemInfo>* key_systems);
jam: This is the tricky part of this CL. In ContentRendererClient, I am using an
struct in media. Is this allowed?

I am doing this because I need to move most part of
content/renderer/media/crypto/key_systems.* to media. So media code will also
need to access KeySystemInfo. An alternative is to keep both
content::KeySystemInfo and media::KeySystemInfo, then do the translation in
content/renderer/media code. But that seems unfortunate and will be hard to
maintain.

Please let me know what you think. Thanks!

[ddorwin, 2014-10-22 22:41:41]

Mostly LG, pending jam's response to your comment in content_renderer_client.h.

https://codereview.chromium.org/665343002/diff/80001/components/cdm/renderer/...
File components/cdm/renderer/BUILD.gn (right):

https://codereview.chromium.org/665343002/diff/80001/components/cdm/renderer/...
components/cdm/renderer/BUILD.gn:21: "//content/public/common",
Do we still need this?

https://codereview.chromium.org/665343002/diff/80001/components/cdm/renderer/...
File components/cdm/renderer/widevine_key_systems.cc (right):

https://codereview.chromium.org/665343002/diff/80001/components/cdm/renderer/...
components/cdm/renderer/widevine_key_systems.cc:19: using media::KeySystemInfo;
Why is this done within the cdm namespace now?

[xhwang, 2014-10-23 16:37:16]

jam: kindly ping!

[jam, 2014-10-23 20:12:23]

lgtm

https://codereview.chromium.org/665343002/diff/80001/content/public/renderer/...
File content/public/renderer/content_renderer_client.h (right):

https://codereview.chromium.org/665343002/diff/80001/content/public/renderer/...
content/public/renderer/content_renderer_client.h:249: virtual void
AddKeySystems(std::vector<media::KeySystemInfo>* key_systems);
On 2014/10/22 07:00:09, xhwang wrote:
> jam: This is the tricky part of this CL. In ContentRendererClient, I am using
an
> struct in media. Is this allowed?
> 
> I am doing this because I need to move most part of
> content/renderer/media/crypto/key_systems.* to media. So media code will also
> need to access KeySystemInfo. An alternative is to keep both
> content::KeySystemInfo and media::KeySystemInfo, then do the translation in
> content/renderer/media code. But that seems unfortunate and will be hard to
> maintain.
> 
> Please let me know what you think. Thanks!

yep this is fine.

see other examples:
https://code.google.com/p/chromium/codesearch#search/&q=%22namespace%20media%...

[boliu, 2014-10-23 20:14:26]

android_webview rs lgtm

[xhwang, 2014-10-23 20:39:16]

ddorwin: PTAL again.

dcheng: Please OWNERS review components/cdm/common/cdm_messages_android.h

https://codereview.chromium.org/665343002/diff/80001/components/cdm/renderer/...
File components/cdm/renderer/BUILD.gn (right):

https://codereview.chromium.org/665343002/diff/80001/components/cdm/renderer/...
components/cdm/renderer/BUILD.gn:21: "//content/public/common",
On 2014/10/22 22:41:41, ddorwin wrote:
> Do we still need this?

Done.

https://codereview.chromium.org/665343002/diff/80001/components/cdm/renderer/...
File components/cdm/renderer/widevine_key_systems.cc (right):

https://codereview.chromium.org/665343002/diff/80001/components/cdm/renderer/...
components/cdm/renderer/widevine_key_systems.cc:19: using media::KeySystemInfo;
On 2014/10/22 22:41:41, ddorwin wrote:
> Why is this done within the cdm namespace now?

Reverted.

[dcheng, 2014-10-23 20:43:44]

dcheng@chromium.org changed required reviewers:
- ddorwin@chromium.org, jam@chromium.org

[dcheng, 2014-10-23 20:43:45]

rslgtm for namespace changes in:
components/cdm/browser/cdm_message_filter_android.cc
components/cdm/common/cdm_messages_android.h

[dcheng, 2014-10-23 20:44:03]

rs lgtm even

[xhwang, 2014-10-23 21:01:31]

rebase only

[ddorwin, 2014-10-23 21:58:50]

LGTM. Thanks

[xhwang, 2014-10-23 22:01:19]

The CQ bit was checked by xhwang@chromium.org

[commit-bot: I haz the power, 2014-10-23 22:03:18]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/665343002/120001

[commit-bot: I haz the power, 2014-10-24 00:03:41]

Committed patchset #3 (id:120001)

[commit-bot: I haz the power, 2014-10-24 00:04:20]

Patchset 3 (id:??) landed as
https://crrev.com/1c03e830f2ab2d83e2bdc96cb399d2a43c77f576
Cr-Commit-Position: refs/heads/master@{#300992}