Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(262)

Issue 665333004: Support the placeholder attribute on Android (Closed)

Created:
6 years, 2 months ago by dmazzoni
Modified:
6 years, 2 months ago
Reviewers:
Peter Lundblad
CC:
chromium-reviews, plundblad+watch_chromium.org, aboxhall+watch_chromium.org, jam, yuzo+watch_chromium.org, darin-cc_chromium.org, dmazzoni+watch_chromium.org, dtseng+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Support the placeholder attribute on Android Note: I still plan to refactor these so that more logic is shared between the platforms, but it's nontrivial. In the meantime I think this is worth it as long as it keeps improving the tests, because that will make the refactoring that much less error-prone. BUG=417104 Committed: https://crrev.com/c3e32b06c2f017310ab6c677e0c7b410c88455cb Cr-Commit-Position: refs/heads/master@{#300706}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -1 line) Patch
M content/browser/accessibility/browser_accessibility_android.cc View 2 chunks +4 lines, -0 lines 0 comments Download
M content/test/data/accessibility/input-text-name-calc-expected-android.txt View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 7 (2 generated)
dmazzoni
6 years, 2 months ago (2014-10-21 20:47:04 UTC) #2
Peter Lundblad
lgtm
6 years, 2 months ago (2014-10-22 12:22:05 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/665333004/1
6 years, 2 months ago (2014-10-22 15:03:41 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
6 years, 2 months ago (2014-10-22 18:08:16 UTC) #6
commit-bot: I haz the power
6 years, 2 months ago (2014-10-22 18:09:26 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/c3e32b06c2f017310ab6c677e0c7b410c88455cb
Cr-Commit-Position: refs/heads/master@{#300706}

Powered by Google App Engine
This is Rietveld 408576698