Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(488)

Issue 66533005: Remove mapToTagName support from ElementFactory generation (Closed)

Created:
7 years, 1 month ago by adamk
Modified:
7 years, 1 month ago
Reviewers:
abarth-chromium
CC:
blink-reviews, buis_samsung.com, Inactive, rob
Visibility:
Public.

Description

Remove mapToTagName support from ElementFactory generation The last usage of it was removed in https://src.chromium.org/viewvc/blink?view=rev&revision=160975 R=abarth@chromium.org BUG=305773 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=161667

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -10 lines) Patch
M Source/build/scripts/make_element_factory.py View 2 chunks +1 line, -2 lines 0 comments Download
M Source/build/scripts/templates/ElementFactory.cpp.tmpl View 2 chunks +1 line, -8 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
adamk
7 years, 1 month ago (2013-11-08 23:45:03 UTC) #1
abarth-chromium
LGTM!
7 years, 1 month ago (2013-11-09 00:06:15 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/adamk@chromium.org/66533005/1
7 years, 1 month ago (2013-11-09 00:06:26 UTC) #3
commit-bot: I haz the power
7 years, 1 month ago (2013-11-09 01:12:39 UTC) #4
Message was sent while issue was closed.
Change committed as 161667

Powered by Google App Engine
This is Rietveld 408576698