chrome/browser/media/chrome_media_stream_infobar_browsertest.cc - Issue 665323004: Standardize usage of virtual/override/final in chrome/browser/media

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/media/chrome_media_stream_infobar_browsertest.cc

Issue 665323004: Standardize usage of virtual/override/final in chrome/browser/media (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 6 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/media/cast_transport_host_filter.h ('k') | chrome/browser/media/chrome_webrtc_apprtc_browsertest.cc » ('j') | chrome/browser/media/chrome_webrtc_apprtc_browsertest.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/media/chrome_media_stream_infobar_browsertest.cc

diff --git a/chrome/browser/media/chrome_media_stream_infobar_browsertest.cc b/chrome/browser/media/chrome_media_stream_infobar_browsertest.cc

index ba6fded58d5605fb01a4918ddebeec6c41505270..d1e44e9bfefd66d77ffc713c6fa355d01a8f85d3 100644

--- a/chrome/browser/media/chrome_media_stream_infobar_browsertest.cc

+++ b/chrome/browser/media/chrome_media_stream_infobar_browsertest.cc

@@ -37,7 +37,7 @@ class MediaStreamInfoBarTest : public WebRtcTestBase {

virtual ~MediaStreamInfoBarTest() {}

scherkus (not reviewing) 2014/10/21 21:53:59 why wasn't this changed? WebRtcTestBase appears t

dcheng 2014/10/21 22:00:18 Beats me. I'll look into this separately.

// InProcessBrowserTest:

- virtual void SetUpCommandLine(CommandLine* command_line) override {

+ void SetUpCommandLine(CommandLine* command_line) override {

// This test expects to run with fake devices but real UI.

command_line->AppendSwitch(switches::kUseFakeDeviceForMediaStream);

EXPECT_FALSE(command_line->HasSwitch(switches::kUseFakeUIForMediaStream))