Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(6960)

Unified Diff: chrome/browser/ui/zoom/chrome_zoom_level_prefs.h

Issue 665283002: Fix crash in ChromeZoomLevelPrefs::ExtractPerHostZoomLevels(). (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@wjmResetZoomLevel
Patch Set: Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/prefs/browser_prefs.cc ('k') | chrome/browser/ui/zoom/chrome_zoom_level_prefs.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/ui/zoom/chrome_zoom_level_prefs.h
diff --git a/chrome/browser/ui/zoom/chrome_zoom_level_prefs.h b/chrome/browser/ui/zoom/chrome_zoom_level_prefs.h
index 8506eb7df690d00f5dd1234ba3acd8c18a59fb82..203c0ffce3789c4ebae32dfd08bf94e26e5e2b43 100644
--- a/chrome/browser/ui/zoom/chrome_zoom_level_prefs.h
+++ b/chrome/browser/ui/zoom/chrome_zoom_level_prefs.h
@@ -53,7 +53,8 @@ class ChromeZoomLevelPrefs {
const base::Closure& callback);
void ExtractPerHostZoomLevels(
- const base::DictionaryValue* host_zoom_dictionary);
+ const base::DictionaryValue* host_zoom_dictionary,
+ const char* dictionary_path);
Bernhard Bauer 2014/10/21 14:13:13 An alternative would be to pass in a boolean that
wjmaclean 2014/10/21 14:21:49 I thought about using a bool, but then with the ge
Bernhard Bauer 2014/10/21 14:26:15 Yeah, I'm absolutely okay with using well-commente
private:
// This is a callback function that receives notifications from HostZoomMap
« no previous file with comments | « chrome/browser/prefs/browser_prefs.cc ('k') | chrome/browser/ui/zoom/chrome_zoom_level_prefs.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698