Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4736)

Unified Diff: chrome/browser/download/download_shelf_context_menu.h

Issue 665253002: Standardize usage of virtual/override/final in chrome/browser/download/ (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/download/download_shelf_context_menu.h
diff --git a/chrome/browser/download/download_shelf_context_menu.h b/chrome/browser/download/download_shelf_context_menu.h
index f5dbf3b3e7f624542ee2aebea0bb5850251f23a4..f7383305b9ba6de61c94b1d129d887348ec8b5ec 100644
--- a/chrome/browser/download/download_shelf_context_menu.h
+++ b/chrome/browser/download/download_shelf_context_menu.h
@@ -37,7 +37,7 @@ class DownloadShelfContextMenu : public ui::SimpleMenuModel::Delegate,
LEARN_MORE_INTERRUPTED,// Show information about interrupted downloads.
};
- virtual ~DownloadShelfContextMenu();
+ ~DownloadShelfContextMenu() override;
content::DownloadItem* download_item() const { return download_item_; }
@@ -50,15 +50,14 @@ class DownloadShelfContextMenu : public ui::SimpleMenuModel::Delegate,
ui::SimpleMenuModel* GetMenuModel();
// ui::SimpleMenuModel::Delegate:
- virtual bool IsCommandIdEnabled(int command_id) const override;
- virtual bool IsCommandIdChecked(int command_id) const override;
- virtual bool IsCommandIdVisible(int command_id) const override;
- virtual void ExecuteCommand(int command_id, int event_flags) override;
- virtual bool GetAcceleratorForCommandId(
- int command_id,
- ui::Accelerator* accelerator) override;
- virtual bool IsItemForCommandIdDynamic(int command_id) const override;
- virtual base::string16 GetLabelForCommandId(int command_id) const override;
+ bool IsCommandIdEnabled(int command_id) const override;
+ bool IsCommandIdChecked(int command_id) const override;
+ bool IsCommandIdVisible(int command_id) const override;
+ void ExecuteCommand(int command_id, int event_flags) override;
+ bool GetAcceleratorForCommandId(int command_id,
+ ui::Accelerator* accelerator) override;
+ bool IsItemForCommandIdDynamic(int command_id) const override;
+ base::string16 GetLabelForCommandId(int command_id) const override;
private:
// Detaches self from |download_item_|. Called when the DownloadItem is
@@ -66,7 +65,7 @@ class DownloadShelfContextMenu : public ui::SimpleMenuModel::Delegate,
void DetachFromDownloadItem();
// content::DownloadItem::Observer
- virtual void OnDownloadDestroyed(content::DownloadItem* download) override;
+ void OnDownloadDestroyed(content::DownloadItem* download) override;
ui::SimpleMenuModel* GetInProgressMenuModel();
ui::SimpleMenuModel* GetFinishedMenuModel();
« no previous file with comments | « chrome/browser/download/download_service_factory.h ('k') | chrome/browser/download/download_status_updater.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698