Standardize usage of virtual/override/final in chrome/browser/download/

chrome/browser/download/download_browsertest.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include <sstream>
 
 #include "base/bind.h"
 #include "base/bind_helpers.h"
 #include "base/command_line.h"
 #include "base/files/file.h"
@@ skipping 101 matching lines @@
 
 namespace {
 
 class CreatedObserver : public content::DownloadManager::Observer {
  public:
   explicit CreatedObserver(content::DownloadManager* manager)
       : manager_(manager),
         waiting_(false) {
     manager->AddObserver(this);
   }
-  virtual ~CreatedObserver() {
+  ~CreatedObserver() override {
     if (manager_)
       manager_->RemoveObserver(this);
   }
 
   void Wait() {
     std::vector<DownloadItem*> downloads;
     manager_->GetAllDownloads(&downloads);
     if (!downloads.empty())
       return;
     waiting_ = true;
     content::RunMessageLoop();
     waiting_ = false;
   }
 
  private:
-  virtual void OnDownloadCreated(content::DownloadManager* manager,
-                                 content::DownloadItem* item) override {
+  void OnDownloadCreated(content::DownloadManager* manager,
+                         content::DownloadItem* item) override {
     DCHECK_EQ(manager_, manager);
     if (waiting_)
       base::MessageLoopForUI::current()->Quit();
   }
 
   content::DownloadManager* manager_;
   bool waiting_;
 
   DISALLOW_COPY_AND_ASSIGN(CreatedObserver);
 };
 
 class PercentWaiter : public content::DownloadItem::Observer {
  public:
   explicit PercentWaiter(DownloadItem* item)
     : item_(item),
       waiting_(false),
       error_(false),
       prev_percent_(0) {
     item_->AddObserver(this);
   }
-  virtual ~PercentWaiter() {
+  ~PercentWaiter() override {
     if (item_)
       item_->RemoveObserver(this);
   }
 
   bool WaitForFinished() {
     if (item_->GetState() == DownloadItem::COMPLETE) {
       return item_->PercentComplete() == 100;
     }
     waiting_ = true;
     content::RunMessageLoop();
     waiting_ = false;
     return !error_;
   }
 
  private:
-  virtual void OnDownloadUpdated(content::DownloadItem* item) override {
+  void OnDownloadUpdated(content::DownloadItem* item) override {
     DCHECK_EQ(item_, item);
     if (!error_ &&
         ((prev_percent_ > item_->PercentComplete()) ||
          (item_->GetState() == DownloadItem::COMPLETE &&
           (item_->PercentComplete() != 100)))) {
       error_ = true;
       if (waiting_)
         base::MessageLoopForUI::current()->Quit();
     }
     if (item_->GetState() == DownloadItem::COMPLETE && waiting_)
       base::MessageLoopForUI::current()->Quit();
   }
 
-  virtual void OnDownloadDestroyed(content::DownloadItem* item) override {
+  void OnDownloadDestroyed(content::DownloadItem* item) override {
     DCHECK_EQ(item_, item);
     item_->RemoveObserver(this);
     item_ = NULL;
   }
 
   content::DownloadItem* item_;
   bool waiting_;
   bool error_;
   int prev_percent_;
 
   DISALLOW_COPY_AND_ASSIGN(PercentWaiter);
 };
 
 // DownloadTestObserver subclass that observes one download until it transitions
 // from a non-resumable state to a resumable state a specified number of
 // times. Note that this observer can only observe a single download.
 class DownloadTestObserverResumable : public content::DownloadTestObserver {
  public:
   // Construct a new observer. |transition_count| is the number of times the
   // download should transition from a non-resumable state to a resumable state.
   DownloadTestObserverResumable(DownloadManager* download_manager,
                                 size_t transition_count)
       : DownloadTestObserver(download_manager, 1,
                              ON_DANGEROUS_DOWNLOAD_FAIL),
         was_previously_resumable_(false),
         transitions_left_(transition_count) {
     Init();
   }
-  virtual ~DownloadTestObserverResumable() {}
+  ~DownloadTestObserverResumable() override {}
 
  private:
-  virtual bool IsDownloadInFinalState(DownloadItem* download) override {
+  bool IsDownloadInFinalState(DownloadItem* download) override {
     bool is_resumable_now = download->CanResume();
     if (!was_previously_resumable_ && is_resumable_now)
       --transitions_left_;
     was_previously_resumable_ = is_resumable_now;
     return transitions_left_ == 0;
   }
 
   bool was_previously_resumable_;
   size_t transitions_left_;
 
@@ skipping 48 matching lines @@
 // Mock that simulates a permissions dialog where the user denies
 // permission to install.  TODO(skerner): This could be shared with
 // extensions tests.  Find a common place for this class.
 class MockAbortExtensionInstallPrompt : public ExtensionInstallPrompt {
  public:
   MockAbortExtensionInstallPrompt() :
       ExtensionInstallPrompt(NULL) {
   }
 
   // Simulate a user abort on an extension installation.
-  virtual void ConfirmInstall(
-      Delegate* delegate,
-      const Extension* extension,
-      const ShowDialogCallback& show_dialog_callback) override {
+  void ConfirmInstall(Delegate* delegate,
+                      const Extension* extension,
+                      const ShowDialogCallback& show_dialog_callback) override {
     delegate->InstallUIAbort(true);
     base::MessageLoopForUI::current()->Quit();
   }
 
-  virtual void OnInstallSuccess(const Extension* extension,
-                                SkBitmap* icon) override {
-  }
-  virtual void OnInstallFailure(
-      const extensions::CrxInstallerError& error) override {
-  }
+  void OnInstallSuccess(const Extension* extension, SkBitmap* icon) override {}
+  void OnInstallFailure(const extensions::CrxInstallerError& error) override {}
 };
 
 // Mock that simulates a permissions dialog where the user allows
 // installation.
 class MockAutoConfirmExtensionInstallPrompt : public ExtensionInstallPrompt {
  public:
   explicit MockAutoConfirmExtensionInstallPrompt(
       content::WebContents* web_contents)
       : ExtensionInstallPrompt(web_contents) {}
 
   // Proceed without confirmation prompt.
-  virtual void ConfirmInstall(
-      Delegate* delegate,
-      const Extension* extension,
-      const ShowDialogCallback& show_dialog_callback) override {
+  void ConfirmInstall(Delegate* delegate,
+                      const Extension* extension,
+                      const ShowDialogCallback& show_dialog_callback) override {
     delegate->InstallUIProceed();
   }
 
-  virtual void OnInstallSuccess(const Extension* extension,
-                                SkBitmap* icon) override {
-  }
-  virtual void OnInstallFailure(
-      const extensions::CrxInstallerError& error) override {
-  }
+  void OnInstallSuccess(const Extension* extension, SkBitmap* icon) override {}
+  void OnInstallFailure(const extensions::CrxInstallerError& error) override {}
 };
 
 static DownloadManager* DownloadManagerForBrowser(Browser* browser) {
   return BrowserContext::GetDownloadManager(browser->profile());
 }
 
 bool WasAutoOpened(DownloadItem* item) {
   return item->GetAutoOpened();
 }
 
@@ skipping 35 matching lines @@
   typedef base::Callback<bool(const history::DownloadRow&)> FilterCallback;
 
   explicit HistoryObserver(Profile* profile)
       : profile_(profile),
         waiting_(false),
         seen_stored_(false) {
     DownloadServiceFactory::GetForBrowserContext(profile_)->
       GetDownloadHistory()->AddObserver(this);
   }
 
-  virtual ~HistoryObserver() {
+  ~HistoryObserver() override {
     DownloadService* service = DownloadServiceFactory::GetForBrowserContext(
         profile_);
     if (service && service->GetDownloadHistory())
       service->GetDownloadHistory()->RemoveObserver(this);
   }
 
   void SetFilterCallback(const FilterCallback& callback) {
     callback_ = callback;
   }
 
-  virtual void OnDownloadStored(
-      content::DownloadItem* item,
-      const history::DownloadRow& info) override {
+  void OnDownloadStored(content::DownloadItem* item,
+                        const history::DownloadRow& info) override {
     if (!callback_.is_null() && (!callback_.Run(info)))
         return;
 
     seen_stored_ = true;
     if (waiting_)
       base::MessageLoopForUI::current()->Quit();
   }
 
-  virtual void OnDownloadHistoryDestroyed() override {
+  void OnDownloadHistoryDestroyed() override {
     DownloadServiceFactory::GetForBrowserContext(profile_)->
       GetDownloadHistory()->RemoveObserver(this);
   }
 
   void WaitForStored() {
     if (seen_stored_)
       return;
     waiting_ = true;
     content::RunMessageLoop();
     waiting_ = false;
@@ skipping 26 matching lines @@
     bool should_redirect_to_documents;  // True if we save it in "My Documents".
   };
 
   struct FileErrorInjectInfo {
     DownloadInfo download_info;
     content::TestFileErrorInjector::FileErrorInfo error_info;
   };
 
   DownloadTest() {}
 
-  virtual void SetUpOnMainThread() override {
+  void SetUpOnMainThread() override {
     BrowserThread::PostTask(
         BrowserThread::IO, FROM_HERE,
         base::Bind(&chrome_browser_net::SetUrlRequestMocksEnabled, true));
     ASSERT_TRUE(InitialSetup());
   }
 
-  virtual void TearDownOnMainThread() override {
+  void TearDownOnMainThread() override {
     // Needs to be torn down on the main thread. file_activity_observer_ holds a
     // reference to the ChromeDownloadManagerDelegate which should be destroyed
     // on the UI thread.
     file_activity_observer_.reset();
   }
 
-  virtual void SetUpCommandLine(CommandLine* command_line) override {
+  void SetUpCommandLine(CommandLine* command_line) override {
     command_line->AppendSwitch(switches::kDisablePluginsDiscovery);
   }
 
   // Returning false indicates a failure of the setup, and should be asserted
   // in the caller.
   virtual bool InitialSetup() {
     bool have_test_dir = PathService::Get(chrome::DIR_TEST_DATA, &test_dir_);
     EXPECT_TRUE(have_test_dir);
     if (!have_test_dir)
       return false;
@@ skipping 3050 matching lines @@
       *(downloads[0])));
 
   // Begin feedback and check that the file is "stolen".
   download_protection_service->feedback_service()->BeginFeedbackForDownload(
       downloads[0]);
   std::vector<DownloadItem*> updated_downloads;
   GetDownloads(browser(), &updated_downloads);
   ASSERT_TRUE(updated_downloads.empty());
 }
 #endif