Experimental app list: Added "All apps" button on start page.

Experimental app list: Added "All apps" button on start page.

This replaces the fifth app icon on the start page. Clicking it
transitions to the apps grid view.

Currently has no icon, and it's a simple slide transition, but
eventually it will have a folder-like icon with a folder open animation.

BUG=425444
Committed: https://crrev.com/189e99138d0a821c5273cec5f6cabeae0d62394b
Cr-Commit-Position: refs/heads/master@{#301778}

[Matt Giuca, 2014-10-22 03:52:02]

mgiuca@chromium.org changed reviewers:
+ calamity@chromium.org

[Matt Giuca, 2014-10-22 03:52:02]

mgiuca@chromium.org changed required reviewers:
+ calamity@chromium.org

[Matt Giuca, 2014-10-22 03:52:02]

OK, so the CL order is:
1. https://codereview.chromium.org/645603003/
2. https://codereview.chromium.org/657793004/
3. this

#2 is kind of redundant now since folder_image.cc is the only file that will
need folder_image_source.h. So maybe I should just abandon #2. But I still like
some of the pieces there (moving static methods around), so ... consider all the
patches together and I can undo parts if you like.

[calamity, 2014-10-23 05:41:00]

I'd prefer the rework we discussed.

https://codereview.chromium.org/665233002/diff/40001/ui/app_list/folder_image.h
File ui/app_list/folder_image.h (right):

https://codereview.chromium.org/665233002/diff/40001/ui/app_list/folder_image...
ui/app_list/folder_image.h:27: virtual void OnIconUpdated(const gfx::ImageSkia&
icon) {}
OnFolderImageUpdated.

[Matt Giuca, 2014-10-24 02:30:22]

For the record, "the rework we discussed" is making a base class for
TileItemView, and adding the "all apps" button as a subclass of that, instead of
adding a new SearchResult class.

https://codereview.chromium.org/665233002/diff/40001/ui/app_list/folder_image.h
File ui/app_list/folder_image.h (right):

https://codereview.chromium.org/665233002/diff/40001/ui/app_list/folder_image...
ui/app_list/folder_image.h:27: virtual void OnIconUpdated(const gfx::ImageSkia&
icon) {}
On 2014/10/23 05:41:00, calamity wrote:
> OnFolderImageUpdated.

Done.

[Matt Giuca, 2014-10-27 23:43:19]

PTAL.

[calamity, 2014-10-28 02:29:44]

lgtm w/ a test to make sure clicking the button goes to the apps page.

https://codereview.chromium.org/665233002/diff/140001/ui/app_list/views/all_a...
File ui/app_list/views/all_apps_tile_item_view.cc (right):

https://codereview.chromium.org/665233002/diff/140001/ui/app_list/views/all_a...
ui/app_list/views/all_apps_tile_item_view.cc:9: #include
"ui/app_list/app_list_item_list.h"
Some of these can be removed.

https://codereview.chromium.org/665233002/diff/140001/ui/app_list/views/all_a...
File ui/app_list/views/all_apps_tile_item_view.h (right):

https://codereview.chromium.org/665233002/diff/140001/ui/app_list/views/all_a...
ui/app_list/views/all_apps_tile_item_view.h:23: // TileItemView overrides:
Overridden from TileItemView:

for consistency.

https://codereview.chromium.org/665233002/diff/140001/ui/app_list/views/start...
File ui/app_list/views/start_page_view.cc (right):

https://codereview.chromium.org/665233002/diff/140001/ui/app_list/views/start...
ui/app_list/views/start_page_view.cc:45: const size_t kNumSearchResultTiles = 5;
FYI, I'm going to be breaking the search out of the start page so don't go to
any special pains to preserve the current behavior.

https://codereview.chromium.org/665233002/diff/140001/ui/app_list/views/tile_...
File ui/app_list/views/tile_item_view.cc (right):

https://codereview.chromium.org/665233002/diff/140001/ui/app_list/views/tile_...
ui/app_list/views/tile_item_view.cc:10: #include "ui/gfx/color_utils.h"
I think you can also remove these. They weren't being used.

[calamity, 2014-10-28 03:18:05]

https://codereview.chromium.org/665233002/diff/140001/ui/app_list/views/tile_...
File ui/app_list/views/tile_item_view.h (right):

https://codereview.chromium.org/665233002/diff/140001/ui/app_list/views/tile_...
ui/app_list/views/tile_item_view.h:29: virtual ~TileItemView();
I think this is override now.

[Matt Giuca, 2014-10-28 06:26:07]

Patchset #9 (id:160001) has been deleted

[Matt Giuca, 2014-10-28 07:22:13]

Patchset #9 (id:180001) has been deleted

[Matt Giuca, 2014-10-28 07:23:19]

Patchset #10 (id:220001) has been deleted

[Matt Giuca, 2014-10-28 07:29:57]

Patchset #10 (id:240001) has been deleted

[Matt Giuca, 2014-10-28 08:02:03]

PTAL.

A bunch of things happened including a huge rebase. So you can either:
a) look at all the non-rebase patch sets since your LGTM on PS 8, or
b) just look at the full change to app_list_view_unittest.cc (which is where
most of the new work is).

https://codereview.chromium.org/665233002/diff/140001/ui/app_list/views/all_a...
File ui/app_list/views/all_apps_tile_item_view.cc (right):

https://codereview.chromium.org/665233002/diff/140001/ui/app_list/views/all_a...
ui/app_list/views/all_apps_tile_item_view.cc:9: #include
"ui/app_list/app_list_item_list.h"
On 2014/10/28 02:29:44, calamity wrote:
> Some of these can be removed.

Done.

https://codereview.chromium.org/665233002/diff/140001/ui/app_list/views/all_a...
File ui/app_list/views/all_apps_tile_item_view.h (right):

https://codereview.chromium.org/665233002/diff/140001/ui/app_list/views/all_a...
ui/app_list/views/all_apps_tile_item_view.h:23: // TileItemView overrides:
This is very inconsistent already; I only ever make sure it's consistent within
the file, otherwise I just write "overrides". Drop the "...ridden from"; it's
cleaner.

https://codereview.chromium.org/665233002/diff/140001/ui/app_list/views/start...
File ui/app_list/views/start_page_view.cc (right):

https://codereview.chromium.org/665233002/diff/140001/ui/app_list/views/start...
ui/app_list/views/start_page_view.cc:45: const size_t kNumSearchResultTiles = 5;
On 2014/10/28 02:29:44, calamity wrote:
> FYI, I'm going to be breaking the search out of the start page so don't go to
> any special pains to preserve the current behavior.

Acknowledged.

https://codereview.chromium.org/665233002/diff/140001/ui/app_list/views/tile_...
File ui/app_list/views/tile_item_view.cc (right):

https://codereview.chromium.org/665233002/diff/140001/ui/app_list/views/tile_...
ui/app_list/views/tile_item_view.cc:10: #include "ui/gfx/color_utils.h"
On 2014/10/28 02:29:44, calamity wrote:
> I think you can also remove these. They weren't being used.

Done.

https://codereview.chromium.org/665233002/diff/140001/ui/app_list/views/tile_...
File ui/app_list/views/tile_item_view.h (right):

https://codereview.chromium.org/665233002/diff/140001/ui/app_list/views/tile_...
ui/app_list/views/tile_item_view.h:29: virtual ~TileItemView();
On 2014/10/28 03:18:05, calamity wrote:
> I think this is override now.

Done.

[calamity, 2014-10-29 00:27:23]

slgtm, gl w/ rb.

[Matt Giuca, 2014-10-29 01:46:41]

A g.

[Matt Giuca, 2014-10-29 01:46:58]

The CQ bit was checked by mgiuca@chromium.org

[commit-bot: I haz the power, 2014-10-29 01:48:05]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/665233002/300001

[commit-bot: I haz the power, 2014-10-29 02:39:20]

Committed patchset #13 (id:300001)

[commit-bot: I haz the power, 2014-10-29 02:40:07]

Patchset 13 (id:??) landed as
https://crrev.com/189e99138d0a821c5273cec5f6cabeae0d62394b
Cr-Commit-Position: refs/heads/master@{#301778}