Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(749)

Issue 665233002: Experimental app list: Added "All apps" button on start page. (Closed)

Created:
6 years, 2 months ago by Matt Giuca
Modified:
6 years, 1 month ago
Reviewers:
*calamity
CC:
chromium-reviews, chrome-apps-syd-reviews_chromium.org, tfarina
Base URL:
https://chromium.googlesource.com/chromium/src.git/+/app-list-factor-folderimagesource
Project:
chromium
Visibility:
Public.

Description

Experimental app list: Added "All apps" button on start page. This replaces the fifth app icon on the start page. Clicking it transitions to the apps grid view. Currently has no icon, and it's a simple slide transition, but eventually it will have a folder-like icon with a folder open animation. BUG=425444 Committed: https://crrev.com/189e99138d0a821c5273cec5f6cabeae0d62394b Cr-Commit-Position: refs/heads/master@{#301778}

Patch Set 1 #

Patch Set 2 : Implemented observer interface so we (eventually) get the correct icon. #

Patch Set 3 : De-duplicate logic between AllAppsSearchResult and AppListFolderItem. #

Total comments: 2

Patch Set 4 : Rebase. #

Patch Set 5 : Renamed OnIconUpdated to OnFolderImageUpdated. #

Patch Set 6 : virtual and override. #

Patch Set 7 : Do the rework discussed (subclass TileItemView rather than SearchResult). #

Patch Set 8 : Split out the code to generate the icon into another CL (it's just white now). #

Total comments: 10

Patch Set 9 : Fix some nits. #

Patch Set 10 : Fix test compile. #

Patch Set 11 : Test all apps button. #

Patch Set 12 : Rebase. #

Patch Set 13 : Rebase. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+261 lines, -85 lines) Patch
M ui/app_list/BUILD.gn View 1 2 3 4 5 6 7 2 chunks +4 lines, -0 lines 0 comments Download
M ui/app_list/app_list.gyp View 1 2 3 4 5 6 7 2 chunks +4 lines, -0 lines 0 comments Download
A ui/app_list/views/all_apps_tile_item_view.h View 1 2 3 4 5 6 7 1 chunk +32 lines, -0 lines 0 comments Download
A ui/app_list/views/all_apps_tile_item_view.cc View 1 2 3 4 5 6 7 8 9 10 11 12 1 chunk +28 lines, -0 lines 0 comments Download
M ui/app_list/views/app_list_view_unittest.cc View 1 2 3 4 5 6 7 8 9 10 11 12 8 chunks +38 lines, -11 lines 0 comments Download
A ui/app_list/views/search_result_tile_item_view.h View 1 2 3 4 5 6 1 chunk +40 lines, -0 lines 0 comments Download
A ui/app_list/views/search_result_tile_item_view.cc View 1 2 3 4 5 6 1 chunk +58 lines, -0 lines 0 comments Download
M ui/app_list/views/start_page_view.h View 1 2 3 4 5 6 7 8 9 10 11 3 chunks +8 lines, -2 lines 0 comments Download
M ui/app_list/views/start_page_view.cc View 1 2 3 4 5 6 7 8 9 10 11 5 chunks +31 lines, -9 lines 0 comments Download
M ui/app_list/views/tile_item_view.h View 1 2 3 4 5 6 7 8 9 10 11 2 chunks +10 lines, -16 lines 0 comments Download
M ui/app_list/views/tile_item_view.cc View 1 2 3 4 5 6 7 8 9 10 11 3 chunks +5 lines, -47 lines 0 comments Download
M ui/strings/ui_strings.grd View 1 chunk +3 lines, -0 lines 0 comments Download

Messages

Total messages: 19 (7 generated)
Matt Giuca
OK, so the CL order is: 1. https://codereview.chromium.org/645603003/ 2. https://codereview.chromium.org/657793004/ 3. this #2 is kind ...
6 years, 2 months ago (2014-10-22 03:52:02 UTC) #3
calamity
I'd prefer the rework we discussed. https://codereview.chromium.org/665233002/diff/40001/ui/app_list/folder_image.h File ui/app_list/folder_image.h (right): https://codereview.chromium.org/665233002/diff/40001/ui/app_list/folder_image.h#newcode27 ui/app_list/folder_image.h:27: virtual void OnIconUpdated(const ...
6 years, 2 months ago (2014-10-23 05:41:00 UTC) #4
Matt Giuca
For the record, "the rework we discussed" is making a base class for TileItemView, and ...
6 years, 2 months ago (2014-10-24 02:30:22 UTC) #5
Matt Giuca
PTAL.
6 years, 1 month ago (2014-10-27 23:43:19 UTC) #6
calamity
lgtm w/ a test to make sure clicking the button goes to the apps page. ...
6 years, 1 month ago (2014-10-28 02:29:44 UTC) #7
calamity
https://codereview.chromium.org/665233002/diff/140001/ui/app_list/views/tile_item_view.h File ui/app_list/views/tile_item_view.h (right): https://codereview.chromium.org/665233002/diff/140001/ui/app_list/views/tile_item_view.h#newcode29 ui/app_list/views/tile_item_view.h:29: virtual ~TileItemView(); I think this is override now.
6 years, 1 month ago (2014-10-28 03:18:05 UTC) #8
Matt Giuca
PTAL. A bunch of things happened including a huge rebase. So you can either: a) ...
6 years, 1 month ago (2014-10-28 08:02:03 UTC) #13
calamity
slgtm, gl w/ rb.
6 years, 1 month ago (2014-10-29 00:27:23 UTC) #14
Matt Giuca
A g.
6 years, 1 month ago (2014-10-29 01:46:41 UTC) #15
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/665233002/300001
6 years, 1 month ago (2014-10-29 01:48:05 UTC) #17
commit-bot: I haz the power
Committed patchset #13 (id:300001)
6 years, 1 month ago (2014-10-29 02:39:20 UTC) #18
commit-bot: I haz the power
6 years, 1 month ago (2014-10-29 02:40:07 UTC) #19
Message was sent while issue was closed.
Patchset 13 (id:??) landed as
https://crrev.com/189e99138d0a821c5273cec5f6cabeae0d62394b
Cr-Commit-Position: refs/heads/master@{#301778}

Powered by Google App Engine
This is Rietveld 408576698