Add a flag to ProfileSyncService that says whether encrypting all data is allowed.

Add a flag to ProfileSyncService that says whether encrypting all data is allowed.

Set that flag to false for supervised users.

BUG=419927
Committed: https://crrev.com/f03588b9e8d1a79ada4d5305df9f7f15fa6d43ea
Cr-Commit-Position: refs/heads/master@{#301354}

[Bernhard Bauer, 2014-10-22 15:35:07]

bauerb@chromium.org changed reviewers:
+ maxbogue@chromium.org, treib@chromium.org, zea@chromium.org

[Bernhard Bauer, 2014-10-22 15:35:08]

Please review. Thanks!

[maxbogue, 2014-10-22 16:06:38]

LGTM

Thanks for doing this so quickly!

[Marc Treib, 2014-10-22 16:10:39]

https://codereview.chromium.org/665223007/diff/20001/chrome/browser/sync/prof...
File chrome/browser/sync/profile_sync_service.cc (right):

https://codereview.chromium.org/665223007/diff/20001/chrome/browser/sync/prof...
chrome/browser/sync/profile_sync_service.cc:2204: encrypt_everything_allowed_ =
allowed;
Hm. Do we need to handle the case when this is set to false after "encrypt
everything" has been enabled? Could we even disable encryption? Or maybe a
LOG(WARNING) is enough?

[Bernhard Bauer, 2014-10-22 16:36:07]

On 2014/10/22 16:10:39, Marc Treib wrote:
>
https://codereview.chromium.org/665223007/diff/20001/chrome/browser/sync/prof...
> File chrome/browser/sync/profile_sync_service.cc (right):
> 
>
https://codereview.chromium.org/665223007/diff/20001/chrome/browser/sync/prof...
> chrome/browser/sync/profile_sync_service.cc:2204: encrypt_everything_allowed_
=
> allowed;
> Hm. Do we need to handle the case when this is set to false after "encrypt
> everything" has been enabled? Could we even disable encryption? Or maybe a
> LOG(WARNING) is enough?

AFAIK, there is currently no way to get back from "everything encrypted" to a
less encrypted state, save for resetting data on the dashboard. We could DCHECK?

[Nicolas Zea, 2014-10-22 16:59:44]

Mostly LG. Would it be possible to add a SyncSetupHandler test?

[Marc Treib, 2014-10-23 07:50:07]

On 2014/10/22 16:36:07, Bernhard Bauer wrote:
> On 2014/10/22 16:10:39, Marc Treib wrote:
> >
>
https://codereview.chromium.org/665223007/diff/20001/chrome/browser/sync/prof...
> > File chrome/browser/sync/profile_sync_service.cc (right):
> > 
> >
>
https://codereview.chromium.org/665223007/diff/20001/chrome/browser/sync/prof...
> > chrome/browser/sync/profile_sync_service.cc:2204:
encrypt_everything_allowed_
> =
> > allowed;
> > Hm. Do we need to handle the case when this is set to false after "encrypt
> > everything" has been enabled? Could we even disable encryption? Or maybe a
> > LOG(WARNING) is enough?
> 
> AFAIK, there is currently no way to get back from "everything encrypted" to a
> less encrypted state, save for resetting data on the dashboard. We could
DCHECK?

Okay, a DCHECK SGTM.

LGTM then!

[Bernhard Bauer, 2014-10-23 12:40:33]

On 2014/10/23 07:50:07, Marc Treib wrote:
> On 2014/10/22 16:36:07, Bernhard Bauer wrote:
> > On 2014/10/22 16:10:39, Marc Treib wrote:
> > >
> >
>
https://codereview.chromium.org/665223007/diff/20001/chrome/browser/sync/prof...
> > > File chrome/browser/sync/profile_sync_service.cc (right):
> > > 
> > >
> >
>
https://codereview.chromium.org/665223007/diff/20001/chrome/browser/sync/prof...
> > > chrome/browser/sync/profile_sync_service.cc:2204:
> encrypt_everything_allowed_
> > =
> > > allowed;
> > > Hm. Do we need to handle the case when this is set to false after "encrypt
> > > everything" has been enabled? Could we even disable encryption? Or maybe a
> > > LOG(WARNING) is enough?
> > 
> > AFAIK, there is currently no way to get back from "everything encrypted" to
a
> > less encrypted state, save for resetting data on the dashboard. We could
> DCHECK?
> 
> Okay, a DCHECK SGTM.
> 
> LGTM then!

Done.

Also added a test.

[Nicolas Zea, 2014-10-23 16:56:47]

LGTM, thanks for the tests!

[Bernhard Bauer, 2014-10-23 18:54:07]

The CQ bit was checked by bauerb@chromium.org

[commit-bot: I haz the power, 2014-10-23 18:55:38]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/665223007/40001

[commit-bot: I haz the power, 2014-10-23 20:00:28]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-10-23 20:00:29]

Try jobs failed on following builders:
  linux_chromium_rel on tryserver.chromium.linux
(http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[Bernhard Bauer, 2014-10-27 12:55:00]

The CQ bit was checked by bauerb@chromium.org

[commit-bot: I haz the power, 2014-10-27 12:55:59]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/665223007/60001

[commit-bot: I haz the power, 2014-10-27 13:40:25]

Committed patchset #4 (id:60001)

[commit-bot: I haz the power, 2014-10-27 13:41:07]

Patchset 4 (id:??) landed as
https://crrev.com/f03588b9e8d1a79ada4d5305df9f7f15fa6d43ea
Cr-Commit-Position: refs/heads/master@{#301354}