Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(246)

Issue 665223004: Adaptation to Skia FontMgr API change (Closed)

Created:
6 years, 2 months ago by Tom Hudson
Modified:
6 years, 2 months ago
CC:
blink-reviews, krit, Rik, jbroman, mkwst+moarreviews_chromium.org, danakj, pdr+graphicswatchlist_chromium.org, Stephen Chennney, rwlbuis, f(malita), klobag.chromium
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Project:
blink
Visibility:
Public.

Description

Adaptation to Skia FontMgr API change Pass multiple locales to font resolution; handles mixed-language documents which need to know device default language to resolve font fallback correctly. Depends on https://codereview.chromium.org/670243002/. BUG=422180 R=djsollen@chromium.org,bungeman@chromium.org,dominik.rottsches@intel.com,eae@chromium.org Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=184380

Patch Set 1 #

Patch Set 2 : Fix lifetime of locale names #

Total comments: 1

Patch Set 3 : Track Ben's API change #

Total comments: 1

Patch Set 4 : Switch to .gypi #

Patch Set 5 : Parallel support for gyp AND gypi #

Unified diffs Side-by-side diffs Delta from patch set Stats (+12 lines, -1 line) Patch
M Source/platform/fonts/android/FontCacheAndroid.cpp View 1 2 1 chunk +10 lines, -1 line 0 comments Download
M public/blink_skia_config.gyp View 1 2 3 4 1 chunk +1 line, -0 lines 0 comments Download
M public/blink_skia_config.gypi View 1 2 3 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 25 (11 generated)
tomhudson
PTAL; if we can land this in tandem with https://codereview.chromium.org/673443003/ it should fix https://code.google.com/p/chromium/issues/detail?id=422180.
6 years, 2 months ago (2014-10-22 16:10:58 UTC) #3
eae
Nice, LGTM
6 years, 2 months ago (2014-10-22 16:12:10 UTC) #4
bungeman-chromium
We will also need to define SK_FM_NEW_MATCH_FAMILY_STYLE_CHARACTER in public/blink_skia_config.gyp . https://codereview.chromium.org/665223004/diff/20001/Source/platform/fonts/android/FontCacheAndroid.cpp File Source/platform/fonts/android/FontCacheAndroid.cpp (right): https://codereview.chromium.org/665223004/diff/20001/Source/platform/fonts/android/FontCacheAndroid.cpp#newcode54 ...
6 years, 2 months ago (2014-10-23 16:55:41 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/665223004/40001
6 years, 2 months ago (2014-10-23 18:52:37 UTC) #7
commit-bot: I haz the power
Try jobs failed on following builders: blink_presubmit on tryserver.blink (http://build.chromium.org/p/tryserver.blink/builders/blink_presubmit/builds/18201)
6 years, 2 months ago (2014-10-23 19:00:08 UTC) #9
bungeman-chromium
lgtm
6 years, 2 months ago (2014-10-23 19:18:00 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/665223004/40001
6 years, 2 months ago (2014-10-23 19:19:32 UTC) #12
commit-bot: I haz the power
Try jobs failed on following builders: win_blink_rel on tryserver.blink (http://build.chromium.org/p/tryserver.blink/builders/win_blink_rel/builds/33344)
6 years, 2 months ago (2014-10-23 19:35:13 UTC) #14
bungeman-chromium
https://codereview.chromium.org/665223004/diff/40001/public/blink_skia_config.gyp File public/blink_skia_config.gyp (right): https://codereview.chromium.org/665223004/diff/40001/public/blink_skia_config.gyp#newcode46 public/blink_skia_config.gyp:46: 'SK_FM_NEW_MATCH_FAMILY_STYLE_CHARACTER=1', Need to rebase this patch now that 'SK_DEFERRED_CANVAS_USES_FACTORIES=1' ...
6 years, 2 months ago (2014-10-24 15:00:54 UTC) #15
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/665223004/60001
6 years, 2 months ago (2014-10-24 18:30:01 UTC) #17
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/665223004/80001
6 years, 2 months ago (2014-10-24 18:35:00 UTC) #20
commit-bot: I haz the power
Try jobs failed on following builders: android_blink_compile_rel on tryserver.blink (http://build.chromium.org/p/tryserver.blink/builders/android_blink_compile_rel/builds/17003)
6 years, 2 months ago (2014-10-24 18:53:03 UTC) #22
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/665223004/80001
6 years, 2 months ago (2014-10-24 19:52:39 UTC) #24
commit-bot: I haz the power
6 years, 2 months ago (2014-10-24 20:03:05 UTC) #25
Message was sent while issue was closed.
Committed patchset #5 (id:80001) as 184380

Powered by Google App Engine
This is Rietveld 408576698