Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(261)

Issue 665223002: Mojo: Fix mojo/public/cpp/application/DEPS. (Closed)

Created:
6 years, 2 months ago by viettrungluu
Modified:
6 years, 2 months ago
Reviewers:
jamesr
CC:
chromium-reviews, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, yzshen+watch_chromium.org, abarth-chromium, Aaron Boodman, darin (slow to review), ben+mojo_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Mojo: Fix mojo/public/cpp/application/DEPS. * We've moved application_runner_chromium. * None of the header files should include .../cpp/utility (in particular, use RunLoop), since the implementations are meant to be replaceable (e.g., by a "Chromium" implementation). * Allow the implementation of ApplicationRunner to use RunLoop. (We could allow it for everything in .../cpp/application/lib, but none of the other things need RunLoop, hence don't need to be replaced.) R=jamesr@chromium.org Committed: https://crrev.com/ed6bbf47c056e285ff5a5077d5d7b4762d9bb002 Cr-Commit-Position: refs/heads/master@{#300421}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -11 lines) Patch
M mojo/public/cpp/application/DEPS View 1 chunk +0 lines, -11 lines 0 comments Download
A mojo/public/cpp/application/lib/DEPS View 1 chunk +5 lines, -0 lines 0 comments Download

Messages

Total messages: 6 (1 generated)
viettrungluu
6 years, 2 months ago (2014-10-21 04:47:53 UTC) #1
jamesr
lgtm
6 years, 2 months ago (2014-10-21 05:03:17 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/665223002/1
6 years, 2 months ago (2014-10-21 05:28:07 UTC) #4
commit-bot: I haz the power
Committed patchset #1 (id:1)
6 years, 2 months ago (2014-10-21 05:31:39 UTC) #5
commit-bot: I haz the power
6 years, 2 months ago (2014-10-21 05:32:24 UTC) #6
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/ed6bbf47c056e285ff5a5077d5d7b4762d9bb002
Cr-Commit-Position: refs/heads/master@{#300421}

Powered by Google App Engine
This is Rietveld 408576698